RESOLVED FIXED51087
WebKit2: Can't add files to an <input type=file> 
https://bugs.webkit.org/show_bug.cgi?id=51087
Summary WebKit2: Can't add files to an <input type=file>
Sam Weinig
Reported 2010-12-14 19:02:49 PST
WebKit2: Can't add files to an <input type=file>
Attachments
Patch to test (DO NOT REVIEW) (69.07 KB, patch)
2010-12-14 19:27 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Also a test! (DO NOT REVIEW) (69.07 KB, patch)
2010-12-14 20:29 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (70.32 KB, patch)
2010-12-15 13:06 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Updated Patch (72.86 KB, patch)
2010-12-15 13:26 PST, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Tester (11 bytes, text/plain)
2010-12-21 18:30 PST, Sam Weinig 		no flags
Details
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-12-14 19:03:01 PST
<rdar://problem/8668718>
Sam Weinig
Comment 2 2010-12-14 19:27:13 PST
Created attachment 76618 [details] Patch to test (DO NOT REVIEW)
Sam Weinig
Comment 3 2010-12-14 20:29:00 PST
Created attachment 76621 [details] Also a test! (DO NOT REVIEW)
Sam Weinig
Comment 4 2010-12-15 13:06:14 PST
Created attachment 76683 [details] Patch
Early Warning System Bot
Comment 5 2010-12-15 13:19:06 PST
Attachment 76683 [details] did not build on qt: Build output: http://queues.webkit.org/results/7158046
Sam Weinig
Comment 6 2010-12-15 13:26:34 PST
Created attachment 76684 [details] Updated Patch
Anders Carlsson
Comment 7 2010-12-15 13:31:40 PST
Comment on attachment 76684 [details] Updated Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76684&action=review > WebKit2/Scripts/webkit2/messages.py:420 > + 'WebKit::WebOpenPanelParameters::Data': '"WebOpenPanelParameters.h"', I don't think this is needed. > WebKit2/Shared/WebOpenPanelParameters.cpp:52 > +{ I usually name the out parameter "result" here. > WebKit2/Shared/WebOpenPanelParameters.h:60 > + WebOpenPanelParameters(const Data&); Please make this explicit. > WebKitTools/MiniBrowser/mac/BrowserWindowController.m:540 > + printf("runOpenPanel callback\n"); Please remove this.
Sam Weinig
Comment 8 2010-12-15 13:53:28 PST
Landed in r74139.
Sam Weinig
Comment 9 2010-12-21 18:30:46 PST
Created attachment 77177 [details] Tester
Note You need to log in before you can comment on or make changes to this bug.