RESOLVED FIXED51070
Percentage Z values in 3d transform functions and transform-origin should cause the property to be invalid 
https://bugs.webkit.org/show_bug.cgi?id=51070
Summary Percentage Z values in 3d transform functions and transform-origin should cau...
Simon Fraser (smfr)
Reported 2010-12-14 16:03:13 PST
I just changed the spec to say that % values in the z-component of translate3d(), translateZ() and transform-origin should make the property invalid. We should implement this.
Attachments
Patch (8.97 KB, patch)
2010-12-14 22:42 PST, Simon Fraser (smfr) 		cmarrin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-12-14 22:04:25 PST
This already works for -webkit-transform-origin.
Simon Fraser (smfr)
Comment 2 2010-12-14 22:42:03 PST
Created attachment 76631 [details] Patch
WebKit Review Bot
Comment 3 2010-12-14 22:43:29 PST
Attachment 76631 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/transforms/2d/resources/transform-test-utils.js', u'LayoutTests/transforms/3d/general/3dtransform-values-expected.txt', u'LayoutTests/transforms/3d/general/3dtransform-values.html', u'WebCore/ChangeLog', u'WebCore/css/CSSParser.cpp']" exit_code: 1 WebCore/css/CSSParser.cpp:5006: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Marrin
Comment 4 2010-12-15 12:02:11 PST
Comment on attachment 76631 [details] Patch r+ with the comment change to get rid of transform-origin wording. You should also fix the style issue, unless it's just noise from the style bot
Simon Fraser (smfr)
Comment 5 2010-12-15 15:51:11 PST
http://trac.webkit.org/changeset/74156
Note You need to log in before you can comment on or make changes to this bug.