Bug 51070 - Percentage Z values in 3d transform functions and transform-origin should cause the property to be invalid
Summary: Percentage Z values in 3d transform functions and transform-origin should cau...
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
Depends on:
Reported: 2010-12-14 16:03 PST by Simon Fraser (smfr)
Modified: 2010-12-15 15:51 PST (History)
4 users (show)

See Also:

Patch (8.97 KB, patch)
2010-12-14 22:42 PST, Simon Fraser (smfr)
cmarrin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-12-14 16:03:13 PST
I just changed the spec to say that % values in the z-component of translate3d(), translateZ() and transform-origin should make the property invalid. We should implement this.
Comment 1 Simon Fraser (smfr) 2010-12-14 22:04:25 PST
This already works for -webkit-transform-origin.
Comment 2 Simon Fraser (smfr) 2010-12-14 22:42:03 PST
Created attachment 76631 [details]
Comment 3 WebKit Review Bot 2010-12-14 22:43:29 PST
Attachment 76631 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/transforms/2d/resources/transform-test-utils.js', u'LayoutTests/transforms/3d/general/3dtransform-values-expected.txt', u'LayoutTests/transforms/3d/general/3dtransform-values.html', u'WebCore/ChangeLog', u'WebCore/css/CSSParser.cpp']" exit_code: 1
WebCore/css/CSSParser.cpp:5006:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 6 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Chris Marrin 2010-12-15 12:02:11 PST
Comment on attachment 76631 [details]

r+ with the comment change to get rid of transform-origin wording. You should also fix the style issue, unless it's just noise from the style bot
Comment 5 Simon Fraser (smfr) 2010-12-15 15:51:11 PST