Bug 51065 - [git].DS_Store should be in .gitignore
Summary: [git].DS_Store should be in .gitignore
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
Depends on:
Reported: 2010-12-14 15:36 PST by Ryosuke Niwa
Modified: 2010-12-14 19:12 PST (History)
6 users (show)

See Also:

Adds *.DS_Store to .gitignore (627 bytes, patch)
2010-12-14 15:39 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Adds .DS_Store to .gitignore (667 bytes, patch)
2010-12-14 15:44 PST, Ryosuke Niwa
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-12-14 15:36:59 PST
AFAIK, there's no point in tracking changes to .DS_Store.  It should be in .gitignore.
Comment 1 Ryosuke Niwa 2010-12-14 15:39:13 PST
Created attachment 76583 [details]
Adds *.DS_Store to .gitignore
Comment 2 Eric Seidel (no email) 2010-12-14 15:42:21 PST
Comment on attachment 76583 [details]
Adds *.DS_Store to .gitignore

You don't need the * , just .DS_Store
Comment 3 Ryosuke Niwa 2010-12-14 15:44:18 PST
Created attachment 76586 [details]
Adds .DS_Store to .gitignore
Comment 4 Eric Seidel (no email) 2010-12-14 15:54:45 PST
Comment on attachment 76586 [details]
Adds .DS_Store to .gitignore

Comment 5 Ryosuke Niwa 2010-12-14 16:19:28 PST
Committed r74067: <http://trac.webkit.org/changeset/74067>
Comment 6 WebKit Review Bot 2010-12-14 17:18:34 PST
http://trac.webkit.org/changeset/74067 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
Comment 7 Ryosuke Niwa 2010-12-14 19:12:01 PST
Thanks for the quick review, Eric.

(In reply to comment #4)
> (From update of attachment 76586 [details])
> ok