Bug 51062 – [chromium] AssociatedURLLoader leaks m_realLoader to its WebURLLoaderClient.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Darin Fisher (:fishd, Google)]

[chromium] AssociatedURLLoader leaks m_realLoader to its WebURLLoaderClient.

AssociatedURLLoader should implement WebURLLoaderClient so that it can intercept
client callbacks and modify the WebURLLoader parameter to be |this|.

[Darin Fisher (:fishd, Google)]

Created attachment 76577 [details]
v1 patch

[Eric Seidel (no email)]

Am I understanding correctly that the WebKit API layer was leaking an internal WebKit (or WebCore?) object?

[Eric Seidel (no email)]

Leaking in the sense of "providing a pointer to".

[Darin Fisher (:fishd, Google)]

(In reply to comment #2)
> Am I understanding correctly that the WebKit API layer was leaking an internal WebKit (or WebCore?) object?

Nope.  AssociatedURLLoader is a WebURLLoader implementation.  It is implemented in terms of the stock WebURLLoader accessible from WebKitClient::createURLLoader().  That internal WebURLLoader was being exposed via WebURLLoaderClient methods.

For background, AssociatedURLLoader is allocated via WebFrame::createAssociatedURLLoader().  That method provides a WebURLLoader implementation that can be used to load an URL that should be treated like a subresource of the frame (e.g., it should be subject to cancellation when window.stop() is called, it should be subject to appcache, etc.).  The present implementation does not do all of these things yet.  I plan on changing AssociatedURLLoader to be based on WebCore::ResourceLoader so that it can.

[Darin Fisher (:fishd, Google)]

Landed as http://trac.webkit.org/changeset/74161