Bug 51051 - commit-queue should upload failure diffs when tests flake
Summary: commit-queue should upload failure diffs when tests flake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-14 12:48 PST by Eric Seidel (no email)
Modified: 2010-12-15 13:48 PST (History)
5 users (show)

See Also:


Attachments
Patch (18.31 KB, patch)
2010-12-14 12:53 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (25.61 KB, patch)
2010-12-15 11:22 PST, Eric Seidel (no email)
abarth: review+
eric: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-12-14 12:48:56 PST
commit-queue should upload failure diffs when tests flake
Comment 1 Eric Seidel (no email) 2010-12-14 12:53:17 PST
Created attachment 76560 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-12-14 12:54:29 PST
This is a first step.  This is going to need more patches.  But this is a very important feature to add to the flaky test reporting.  if this works out we can add this feature to other bots as well. :)
Comment 3 Adam Barth 2010-12-14 13:45:20 PST
I'll look at this tonight.
Comment 4 Eric Seidel (no email) 2010-12-15 11:22:53 PST
Created attachment 76672 [details]
Patch
Comment 5 Adam Barth 2010-12-15 11:30:36 PST
Comment on attachment 76672 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76672&action=review

> WebKitTools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:449
> +        if hasattr(file_or_string, 'read'):
> +            return file_or_string

This is kind of a hack.

> WebKitTools/Scripts/webkitpy/tool/main.py:75
> +        self.filesystem = FileSystem()

Nice.  This has been a long time coming.
Comment 6 Eric Seidel (no email) 2010-12-15 13:39:27 PST
Comment on attachment 76672 [details]
Patch

Fixing a /diff/diffs/ typo, one sec.
Comment 7 Eric Seidel (no email) 2010-12-15 13:48:56 PST
Committed r74138: <http://trac.webkit.org/changeset/74138>