Bug 51034 - Web Inspector: Rule data not updated in Styles pane after stylesheet gets reverted
Summary: Web Inspector: Rule data not updated in Styles pane after stylesheet gets rev...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-14 06:58 PST by Alexander Pavlov (apavlov)
Modified: 2010-12-14 10:06 PST (History)
10 users (show)

See Also:

Attachments
[PATCH] Suggested fix (2.99 KB, patch)
2010-12-14 08:25 PST, Alexander Pavlov (apavlov) 		yurys: review-
Details | Formatted Diff | Diff
[PATCH] Comment addressed (3.22 KB, patch)
2010-12-14 09:36 PST, Alexander Pavlov (apavlov) 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2010-12-14 06:58:42 PST 
After a stylesheet is reverted in the Resources panel, the rule data for the current element do not get updated, even if the revert has altered the respective styles.
Comment 1 Alexander Pavlov (apavlov) 2010-12-14 08:25:36 PST 
Created attachment 76539 [details]
[PATCH] Suggested fix
Comment 2 Yury Semikhatsky 2010-12-14 09:08:26 PST 
Comment on attachment 76539 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=76539&action=review

> WebCore/inspector/front-end/CSSStyleModel.js:177
> +            if (WebInspector.panels.elements)

The panel should listen to changes in the model. The model could send such notifications from _styleSheetChanged a change has been successfully committed.
Comment 3 Alexander Pavlov (apavlov) 2010-12-14 09:36:31 PST 
Created attachment 76542 [details]
[PATCH] Comment addressed
Comment 4 Alexander Pavlov (apavlov) 2010-12-14 10:06:53 PST 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/inspector/front-end/CSSStyleModel.js
        M       WebCore/inspector/front-end/ElementsPanel.js
Committed r74038