Bug 51025 - Web Inspector: regroup Inspector.idl entries.
Summary: Web Inspector: regroup Inspector.idl entries.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks: 51293
  Show dependency treegraph
 
Reported: 2010-12-14 03:58 PST by Ilya Tikhonovsky
Modified: 2019-05-02 22:53 PDT (History)
20 users (show)

See Also:


Attachments
[patch] first version (21.79 KB, patch)
2010-12-14 04:03 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Inspector.idl (15.81 KB, text/x-idl)
2010-12-14 04:03 PST, Ilya Tikhonovsky
no flags Details
[patch] extended version with comments (25.46 KB, patch)
2010-12-14 06:18 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-12-14 03:58:27 PST
just for better visibility.
Comment 1 Ilya Tikhonovsky 2010-12-14 04:03:06 PST
Created attachment 76524 [details]
[patch] first version
Comment 2 Ilya Tikhonovsky 2010-12-14 04:03:53 PST
Created attachment 76525 [details]
Inspector.idl
Comment 3 Ilya Tikhonovsky 2010-12-14 06:18:46 PST
Created attachment 76529 [details]
[patch] extended version with comments
Comment 4 Ilya Tikhonovsky 2010-12-14 06:54:55 PST
Comment on attachment 76529 [details]
[patch] extended version with comments

Clearing flags on attachment: 76529

Committed r74022: <http://trac.webkit.org/changeset/74022>
Comment 5 Ilya Tikhonovsky 2010-12-14 06:55:06 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Joseph Pecoraro 2010-12-14 09:30:27 PST
Comment on attachment 76529 [details]
[patch] extended version with comments

View in context: https://bugs.webkit.org/attachment.cgi?id=76529&action=review

> WebCore/inspector/Inspector.idl:132
> +#if defined(ENABLE_OFFLINE_WEB_APPLICATIONS) && ENABLE_OFFLINE_WEB_APPLICATIONS
> +        [notify, domain=Resources] void updateApplicationCacheStatus(out int status);
> +        [notify, domain=Resources] void updateNetworkState(out boolean isNowOnline);
> +#endif
> +#if defined(ENABLE_OFFLINE_WEB_APPLICATIONS) && ENABLE_OFFLINE_WEB_APPLICATIONS
> +        [domain=ApplicationCache] void getApplicationCaches(out Value applicationCaches);
> +#endif

These can just be wrapped in one #if, since they are the same.