Bug 51012 – Kana should be part of CJK Ideographs in WebCore/platform/graphics/Font.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Koan-Sin Tan]

Created attachment 76497 [details]
Kata not displayed right in vertical text

Katakana and hiragana should be considered part of CJK Ideographs, otherwise they are not displayed correctly in vertical writing

[Koan-Sin Tan]

Created attachment 76500 [details]
Proposed patch

Add the following to CJK ideographs:
hiragana: U+3040 - U+309F
katakana: U+30A0 - U+30FF
Halfwidth and Fullwidth Forms: U+FF00 - U+FFEF

Glyphs in Halfwidth and Fullwidth Forms are widely used in CJK. They are mostly used in CJK, I think.

[Koan-Sin Tan]

Created attachment 76508 [details]
Proposed patch

Same as 76500, updated to change WebCore::Font::isCJKIdeographOrSymbol introduced in http://trac.webkit.org/changeset/74005 instead of WebCore::Font::isCJKIdeograph

[Koan-Sin Tan]

Created attachment 76510 [details]
kana displayed correctly after the patch is applied

Yes, I know it's broken font, but sometimes people use broken font :-)

[Alexey Proskuryakov]

Comment on attachment 76508 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76508&action=review

All these checks look slow. I don't know if this is a practical problem.

> LayoutTests/ChangeLog:8
> +        Test if kana displayed correctly in vertical text with broken font.

The test should have expected results, see <http://webkit.org/coding/contributing.html>.

[Koan-Sin Tan]

(In reply to comment #4)
> (From update of attachment 76508 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=76508&action=review
> 
> All these checks look slow. I don't know if this is a practical problem.

you have to deal with it anyway, right?
how about combining checks of contiguous blocks, such as hiragana and katakana?
or try to come up some magic arithmetic?

> > LayoutTests/ChangeLog:8
> > +        Test if kana displayed correctly in vertical text with broken font.
> 
> The test should have expected results, see <http://webkit.org/coding/contributing.html>.

Will do that, thanks.

[Alexey Proskuryakov]

This was just a comment in passing, please don't implement any optimizations unless profiling show that this is hot code.

[Koan-Sin Tan]

Created attachment 76594 [details]
modified patch with expected result added

Same as 76508. Added expected results.

[Koan-Sin Tan]

Created attachment 76597 [details]
patch with expected results

Same as 76594. Deleted a stupid \n introduced by copy-and-paste

[WebKit Commit Bot]

Comment on attachment 76597 [details]
patch with expected results

Clearing flags on attachment: 76597

Committed r74096: <http://trac.webkit.org/changeset/74096>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.