Bug 51011 - WebKit2: Need to be able to set the application name for the user agent for a WKPage
Summary: WebKit2: Need to be able to set the application name for the user agent for a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-13 21:33 PST by Sam Weinig
Modified: 2010-12-13 21:49 PST (History)
0 users

See Also:

Attachments
Patch (28.76 KB, patch)
2010-12-13 21:40 PST, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-12-13 21:33:51 PST 
We need to be able to set the application name for the user agent for a WKPage.
Comment 1 Sam Weinig 2010-12-13 21:40:03 PST 
Created attachment 76496 [details]
Patch
Comment 2 Anders Carlsson 2010-12-13 21:45:43 PST 
Comment on attachment 76496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76496&action=review

Maybe we should move the user agent computation code to WebCore so that it can be shared between WebKit1 and WebKit2?

> WebKit2/UIProcess/WebPageProxy.cpp:631
> +        return;

Doesn't seem like this check is needed here.

> WebKit2/UIProcess/WebPageProxy.h:404
> +    static String standardUserAgent(const String& = String());

I think leaving out the parameter name here just leads to confusion.
Comment 3 Sam Weinig 2010-12-13 21:49:33 PST 
Landed in r74000.