Bug 50965 - [v8] Next round of CSS GC story: proper grouping of CSSStyleDeclarations
Summary: [v8] Next round of CSS GC story: proper grouping of CSSStyleDeclarations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: anton muhin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-13 13:35 PST by anton muhin
Modified: 2010-12-15 02:58 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.62 KB, patch)
2010-12-13 14:31 PST, anton muhin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description anton muhin 2010-12-13 13:35:48 PST 
[v8] Next round of CSS GC story: proper grouping of CSSStyleDeclarations
Comment 1 anton muhin 2010-12-13 14:31:48 PST 
Created attachment 76443 [details]
Patch
Comment 2 David Levin 2010-12-13 19:40:44 PST 
Looks fine, but shouldn't some items be removed from test expectations (for chromium) with this change?
Comment 3 anton muhin 2010-12-14 06:32:29 PST 
Call me paranoid, but I'd prefer to land the fix first and then check on canaries it indeed fixes the trouble for all the platforms.  Then I am doing a tiny expectations cleanup.  

But if you think this commits duplication is stupid, just say so and I'll update the patch, of course.

And thanks a lot for review!

(In reply to comment #2)
> Looks fine, but shouldn't some items be removed from test expectations (for chromium) with this change?
Comment 4 WebKit Commit Bot 2010-12-15 02:58:12 PST 
Comment on attachment 76443 [details]
Patch

Clearing flags on attachment: 76443

Committed r74106: <http://trac.webkit.org/changeset/74106>
Comment 5 WebKit Commit Bot 2010-12-15 02:58:17 PST 
All reviewed patches have been landed.  Closing bug.