Bug 50945 – WebKit2: Web Inspector windows don't have titles

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brian Weinstein]

In WebKit2, Web Inspector windows don't have titles. We need to listen to when the inspected URL has changed, and update the title through that.

[Brian Weinstein]

<rdar://problem/8762410>

[Timothy Hatcher]

Created attachment 83229 [details]
Proposed Change

[Adam Roben (:aroben)]

Comment on attachment 83229 [details]
Proposed Change

You might want to give the Windows and Qt EWS a chance to chew on this.

[Timothy Hatcher]

Created attachment 83235 [details]
Proposed Change (with Qt and GTK fixed)

[Adam Roben (:aroben)]

Comment on attachment 83235 [details]
Proposed Change (with Qt and GTK fixed)

View in context: https://bugs.webkit.org/attachment.cgi?id=83235&action=review

> Source/WebKit2/UIProcess/gtk/WebInspectorGtk.cpp:55
> +void WebInspectorProxy::platformInspectedURLChanged(const String& urlString)

Could remove the urlString name here.

> Source/WebKit2/UIProcess/qt/WebInspectorProxyQt.cpp:54
> +void WebInspectorProxy::platformInspectedURLChanged(const String& urlString)

And here.

> Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:191
> +    ::SetWindowText(m_inspectorWindow, title.charactersWithNullTermination());

You should change this to call ::SetWindowTextW, to match other Win32 API usage in WebKit2. (::SetWindowText is just a macro for ::SetWindowTextW, so there's no behavioral difference.)

[Timothy Hatcher]

(In reply to comment #5)
> (From update of attachment 83235 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83235&action=review
> 
> > Source/WebKit2/UIProcess/gtk/WebInspectorGtk.cpp:55
> > +void WebInspectorProxy::platformInspectedURLChanged(const String& urlString)
> 
> Could remove the urlString name here.
> 
> > Source/WebKit2/UIProcess/qt/WebInspectorProxyQt.cpp:54
> > +void WebInspectorProxy::platformInspectedURLChanged(const String& urlString)
> 
> And here.
> 
> > Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:191
> > +    ::SetWindowText(m_inspectorWindow, title.charactersWithNullTermination());
> 
> You should change this to call ::SetWindowTextW, to match other Win32 API usage in WebKit2. (::SetWindowText is just a macro for ::SetWindowTextW, so there's no behavioral difference.)

All done. Thanks!

[Timothy Hatcher]

Created attachment 83237 [details]
Proposed Change (with Adam's feedback)

[Timothy Hatcher]

Fixed in r79273.