Bug 50942 - Move caret-browsing related layout tests out of platform/gtk
Summary: Move caret-browsing related layout tests out of platform/gtk
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on: 25533 50536
  Show dependency treegraph
Reported: 2010-12-13 10:33 PST by Mario Sanchez Prada
Modified: 2010-12-18 22:55 PST (History)
3 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2010-12-13 10:33:13 PST
As it was pointed out in comment #43 for bug 25526 (https://bugs.webkit.org/show_bug.cgi?id=25526#c43), and properly tracked down through bug 50536, GTK is about to stop being the only platform implementing caret browsing mode (well, Mac has the VO cursor, which is a similar thing but a different implementation) since Qt is going to support it too. Hence, it would be interesting to have all those Layout tests out of platform/gtk, where they normally are nowadays.

Current proposal to fix this bug would therefore be to do the following:

  * Move all the caret-browsing related Layout tests out from platform/gtk to editing/caret-browsing. (I think this would be a good place to put them all, but if somebody has a better suggestion it would be awesome to share it)

  * Put the moved tests in the Skipped files for all platforms but GTK, which would be the only one initially passing all of them.

  * Further tests related to caret-browsing should be placed under that path, and initially skipped in all platforms but the one adding them.

As there's currently a couple of patches pending on review which would add these kind of tests under platform/gtk (see bug 27048 and bug 25533), my personal proposal it's to keep the current policy of adding them as platform specific, and after both of them get integrated, providing a patch to fix this bug but moving all the tests together to the right place. That's why I'm settting this bug as dependant on those.

This way we have the double benefit of not messing things up in patches currently on review while, at the same time, leaving room to think about this bug and the proposal itself (such as if the right destination path should be editing/caret-browsing, or somewhere else).
Comment 1 Mario Sanchez Prada 2010-12-13 10:41:12 PST
Depending on bug 50536 as well, as the patch for it also involves moving a test from platform/gtk to editing/selection. Hence, it would be nice we wouldn't be proposing a patch for this one until that one gets integrated too, to avoid conflicts.

Btw, I wonder whether that could mean that perhaps it's better to move the patches to editing/selection instead of editing/caret-browsing, as proposed in this bug's description. IMHO, I think it's better to create a editing/caret-browsing directory to differentiate tests that are just checking the caret position in certain situations (those usually under editing/selection/*caret*html) from those testing caret navigation in caret browsing mode, which is what this bug is actually about.

Comment 2 Mario Sanchez Prada 2010-12-13 11:04:56 PST
(In reply to comment #0)
> As there's currently a couple of patches pending on review which would add these kind of tests under platform/gtk (see bug 27048 and bug 25533), [...]

My mistake, sorry. bug 27048 shouldn't be blocking this one since it provides an GTK-specific accessibility layout test (even if it's related with caretbrowsing).

Removing from the list of dependencies. Sorry for the hassle.
Comment 3 Mario Sanchez Prada 2010-12-14 01:27:50 PST
I need to get more quality sleep time... it was bug 25533 what this one should be blocking, not 25333 :/
Comment 4 Antonio Gomes 2010-12-18 22:55:51 PST
> Opinions?

I like editing/caret-browsing