Bug 50915 - [GTK] Do not use GET_PRIVATE macros
Summary: [GTK] Do not use GET_PRIVATE macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-13 04:39 PST by Carlos Garcia Campos
Modified: 2010-12-13 06:17 PST (History)
4 users (show)

See Also:


Attachments
Patch to remove GET_PRIVATE macros (29.46 KB, patch)
2010-12-13 04:42 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2010-12-13 04:39:55 PST
GET_PRIVATE macros are slow and should only be used in the object init() method. We are currently using a pointer to the private structure in the instance structure so we don't need to call GET_PRIVATE. There are only a few places where GET_PRIVATE macros are used, but since they are confusing and useless (it's macro for something that it's going to be used only once), I think we can just remove them all to make sure they are not used anymore.
Comment 1 Carlos Garcia Campos 2010-12-13 04:42:39 PST
Created attachment 76370 [details]
Patch to remove GET_PRIVATE macros
Comment 2 WebKit Commit Bot 2010-12-13 05:27:37 PST
Comment on attachment 76370 [details]
Patch to remove GET_PRIVATE macros

Clearing flags on attachment: 76370

Committed r73906: <http://trac.webkit.org/changeset/73906>
Comment 3 WebKit Commit Bot 2010-12-13 05:27:41 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2010-12-13 06:17:40 PST
http://trac.webkit.org/changeset/73906 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
editing/selection/extend-by-character-002.html