Bug 50896 - WebKit2: Implement WebInspector::localizedStringsURL on Windows
Summary: WebKit2: Implement WebInspector::localizedStringsURL on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2010-12-12 12:31 PST by Brian Weinstein
Modified: 2010-12-12 20:42 PST (History)
11 users (show)

See Also:

Attachments
[PATCH] Fix (1.53 KB, patch)
2010-12-12 12:37 PST, Brian Weinstein 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2010-12-12 12:31:55 PST 
This function needs to be implemented.
Comment 1 Brian Weinstein 2010-12-12 12:32:17 PST 
<rdar://problem/8759907>
Comment 2 Brian Weinstein 2010-12-12 12:37:05 PST 
Created attachment 76332 [details]
[PATCH] Fix
Comment 3 Timothy Hatcher 2010-12-12 12:41:14 PST 
Comment on attachment 76332 [details]
[PATCH] Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=76332&action=review

> WebKit2/WebProcess/WebPage/win/WebInspectorWin.cpp:38
> +    RetainPtr<CFURLRef> htmlURLRef(AdoptCF, CFBundleCopyResourceURL(CFBundleGetBundleWithIdentifier(CFSTR("com.apple.WebKit")), CFSTR("localizedStrings"), CFSTR("js"), 0));
> +    if (!htmlURLRef)

The variable should be localizedStringsURLRef not htmlURLRef.

> WebKit2/WebProcess/WebPage/win/WebInspectorWin.cpp:41
> +    return String(CFURLGetString(htmlURLRef.get()));

Ditto.
Comment 4 Brian Weinstein 2010-12-12 20:39:26 PST 
Comment on attachment 76332 [details]
[PATCH] Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=76332&action=review

>> WebKit2/WebProcess/WebPage/win/WebInspectorWin.cpp:38
>> +    if (!htmlURLRef)
> 
> The variable should be localizedStringsURLRef not htmlURLRef.

Fixed.
Comment 5 Brian Weinstein 2010-12-12 20:42:29 PST 
Landed in r73884.