Bug 50894 – [Qt] Assert at WebContext destruction

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit2

[Balazs Kelemen]

If the WebContext has a valid (not invalidated) WebDatabaseManagerProxy than it asserts in it's destructor:
ASSERTION FAILED: !m_context at WebDataBaseProxy.cpp:49 (this is hand written but I am not lying :) )
The assumption that the manager must be invalidated when the context is getting destructed seems to be pointless. The bug only appears on Qt but I think the reason of that is that other ports do not destruct the context at termination, but that should be possible.

[Balazs Kelemen]

Created attachment 76328 [details]
Patch

[Jessie Berlin]

I am not a reviewer, but this patch looks fine to me.

[Andreas Kling]

Comment on attachment 76328 [details]
Patch

r=me

Thanks Jessie for looking :)

[Eric Seidel (no email)]

Attachment 76328 [details] was posted by a committer and has review+, assigning to Balazs Kelemen for commit.

[WebKit Commit Bot]

Comment on attachment 76328 [details]
Patch

Rejecting attachment 76328 [details] from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-attachment', '--non-interactive', 76328]" exit_code: 2
Last 500 characters of output:
ripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file WebKit2/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit2/UIProcess/WebDatabaseManagerProxy.cpp
Hunk #1 FAILED at 46.
1 out of 1 hunk FAILED -- saving rejects to file WebKit2/UIProcess/WebDatabaseManagerProxy.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7108094

[Balazs Kelemen]

Sorry, I totally forgot about this. In the meantime http://trac.webkit.org/changeset/73879 solved the problem.
The invalidate call in the destructor (that is the difference of this patch and r73879) is not needed so that fix is correct.