Bug 50894 - [Qt] Assert at WebContext destruction
Summary: [Qt] Assert at WebContext destruction
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Balazs Kelemen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-12 08:13 PST by Balazs Kelemen
Modified: 2010-12-17 04:07 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.32 KB, patch)
2010-12-12 08:21 PST, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2010-12-12 08:13:01 PST
If the WebContext has a valid (not invalidated) WebDatabaseManagerProxy than it asserts in it's destructor:
ASSERTION FAILED: !m_context at WebDataBaseProxy.cpp:49 (this is hand written but I am not lying :) )
The assumption that the manager must be invalidated when the context is getting destructed seems to be pointless. The bug only appears on Qt but I think the reason of that is that other ports do not destruct the context at termination, but that should be possible.
Comment 1 Balazs Kelemen 2010-12-12 08:21:08 PST
Created attachment 76328 [details]
Patch
Comment 2 Jessie Berlin 2010-12-12 10:24:21 PST
I am not a reviewer, but this patch looks fine to me.
Comment 3 Andreas Kling 2010-12-13 03:05:44 PST
Comment on attachment 76328 [details]
Patch

r=me

Thanks Jessie for looking :)
Comment 4 Eric Seidel (no email) 2010-12-14 15:14:25 PST
Attachment 76328 [details] was posted by a committer and has review+, assigning to Balazs Kelemen for commit.
Comment 5 WebKit Commit Bot 2010-12-16 17:53:49 PST
Comment on attachment 76328 [details]
Patch

Rejecting attachment 76328 [details] from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-attachment', '--non-interactive', 76328]" exit_code: 2
Last 500 characters of output:
ripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file WebKit2/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit2/UIProcess/WebDatabaseManagerProxy.cpp
Hunk #1 FAILED at 46.
1 out of 1 hunk FAILED -- saving rejects to file WebKit2/UIProcess/WebDatabaseManagerProxy.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7108094
Comment 6 Balazs Kelemen 2010-12-17 04:07:18 PST
Sorry, I totally forgot about this. In the meantime http://trac.webkit.org/changeset/73879 solved the problem.
The invalidate call in the destructor (that is the difference of this patch and r73879) is not needed so that fix is correct.