Bug 50893 - Web Inspector: [REGRESSION] Cmd (Ctrl) + G does not search next in Scripts panel.
Summary: Web Inspector: [REGRESSION] Cmd (Ctrl) + G does not search next in Scripts pa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-12 07:04 PST by Pavel Feldman
Modified: 2011-01-11 04:43 PST (History)
12 users (show)

See Also:


Attachments
[PATCH] Proposed change (3.10 KB, patch)
2010-12-17 03:15 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
[PATCH] Even better fix. (4.01 KB, patch)
2010-12-17 03:19 PST, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-12-12 07:04:10 PST
Currently invokes Go-to-line. This should be fixed since shortcuts are published in the documentation. Please use Cmd+L (Ctrl+L) instead of G.
Comment 1 Alexander Pavlov (apavlov) 2010-12-12 10:07:01 PST
(In reply to comment #0)
> Currently invokes Go-to-line. This should be fixed since shortcuts are published in the documentation. Please use Cmd+L (Ctrl+L) instead of G.

As per the shortcut help inside DevTools (F1), Ctrl+L is assigned to the "Clear Console" action.
Comment 2 Alexey Proskuryakov 2010-12-13 10:39:55 PST
JFYI: another shortcut for Go To Line familiar to some Web developers would be Cmd+J (as in TextWrangler/BBEdit).

Obviously, Cmd+G/Cmd+Shift+G for Search Next/Previous are the best known and most important of the bunch.
Comment 3 Pavel Feldman 2010-12-17 03:15:25 PST
Created attachment 76863 [details]
[PATCH] Proposed change
Comment 4 Pavel Feldman 2010-12-17 03:19:10 PST
Created attachment 76864 [details]
[PATCH] Even better fix.
Comment 5 Yury Semikhatsky 2010-12-17 04:37:56 PST
Comment on attachment 76864 [details]
[PATCH] Even better fix.

View in context: https://bugs.webkit.org/attachment.cgi?id=76864&action=review

> WebCore/inspector/front-end/inspector.js:880
> +            if (isMac && event.metaKey && !event.ctrlKey && !event.altKey) {

Before landing, please make sure that Enter/Shift+Enter works in Chromium on Linux
Comment 6 Pavel Feldman 2010-12-17 04:52:50 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ScriptsPanel.js
	M	WebCore/inspector/front-end/inspector.js
Committed r74253
Comment 7 Nico Weber 2010-12-20 09:54:17 PST
Howdy,

cmd-l is "focus address bar" in both chrome and safari. Can you use a different shortcut for "go to line"?
Comment 8 Yury Semikhatsky 2010-12-21 04:19:48 PST
We should pick a shortcut that wouldn't conflict with other actions in docked mode too.
Comment 9 Eric Seidel (no email) 2011-01-11 03:13:25 PST
Did this land?
Comment 10 Pavel Feldman 2011-01-11 04:43:34 PST
(In reply to comment #8)
> We should pick a shortcut that wouldn't conflict with other actions in docked mode too.

Cmd+L now should do go-to-line while focus is in inspector, default action otherwise. Lets see now annoying that is - I see no better options so far.