RESOLVED FIXED50893
Web Inspector: [REGRESSION] Cmd (Ctrl) + G does not search next in Scripts panel. 
https://bugs.webkit.org/show_bug.cgi?id=50893
Summary Web Inspector: [REGRESSION] Cmd (Ctrl) + G does not search next in Scripts pa...
Pavel Feldman
Reported 2010-12-12 07:04:10 PST
Currently invokes Go-to-line. This should be fixed since shortcuts are published in the documentation. Please use Cmd+L (Ctrl+L) instead of G.
Attachments
[PATCH] Proposed change (3.10 KB, patch)
2010-12-17 03:15 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[PATCH] Even better fix. (4.01 KB, patch)
2010-12-17 03:19 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2010-12-12 10:07:01 PST
(In reply to comment #0) > Currently invokes Go-to-line. This should be fixed since shortcuts are published in the documentation. Please use Cmd+L (Ctrl+L) instead of G. As per the shortcut help inside DevTools (F1), Ctrl+L is assigned to the "Clear Console" action.
Alexey Proskuryakov
Comment 2 2010-12-13 10:39:55 PST
JFYI: another shortcut for Go To Line familiar to some Web developers would be Cmd+J (as in TextWrangler/BBEdit). Obviously, Cmd+G/Cmd+Shift+G for Search Next/Previous are the best known and most important of the bunch.
Pavel Feldman
Comment 3 2010-12-17 03:15:25 PST
Created attachment 76863 [details] [PATCH] Proposed change
Pavel Feldman
Comment 4 2010-12-17 03:19:10 PST
Created attachment 76864 [details] [PATCH] Even better fix.
Yury Semikhatsky
Comment 5 2010-12-17 04:37:56 PST
Comment on attachment 76864 [details] [PATCH] Even better fix. View in context: https://bugs.webkit.org/attachment.cgi?id=76864&action=review > WebCore/inspector/front-end/inspector.js:880 > + if (isMac && event.metaKey && !event.ctrlKey && !event.altKey) { Before landing, please make sure that Enter/Shift+Enter works in Chromium on Linux
Pavel Feldman
Comment 6 2010-12-17 04:52:50 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ScriptsPanel.js M WebCore/inspector/front-end/inspector.js Committed r74253
Nico Weber
Comment 7 2010-12-20 09:54:17 PST
Howdy, cmd-l is "focus address bar" in both chrome and safari. Can you use a different shortcut for "go to line"?
Yury Semikhatsky
Comment 8 2010-12-21 04:19:48 PST
We should pick a shortcut that wouldn't conflict with other actions in docked mode too.
Eric Seidel (no email)
Comment 9 2011-01-11 03:13:25 PST
Did this land?
Pavel Feldman
Comment 10 2011-01-11 04:43:34 PST
(In reply to comment #8) > We should pick a shortcut that wouldn't conflict with other actions in docked mode too. Cmd+L now should do go-to-line while focus is in inspector, default action otherwise. Lets see now annoying that is - I see no better options so far.
Note You need to log in before you can comment on or make changes to this bug.