Bug 50892 – [Qt][WK2] Crash in WebPage constructor

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Balazs Kelemen]

WebPage initializing it's Page with a PageClients with zero DeviceMotionClient* that leads to 
zero pointer dereference. This is how Page using the clients:
#if ENABLE(DEVICE_ORIENTATION)
    , m_deviceMotionController(RuntimeEnabledFeatures::deviceMotionEnabled() ? new DeviceMotionController(pageClients.deviceMotionClient) : 0)
    , m_deviceOrientationController(RuntimeEnabledFeatures::deviceOrientationEnabled() ? new DeviceOrientationController(this, pageClients.deviceOrientationClient) : 0)
#endif

That means the correct fix is to disable the device motion and orientation features at runtime. The WebPage contructor also needs a fix for consistency with the enable flags but that should be done in a different patch.

[Balazs Kelemen]

Created attachment 76326 [details]
Patch

[Andreas Kling]

Comment on attachment 76326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76326&action=review

LGTM, except one small and one big thing:

> WebKit2/WebProcess/qt/WebProcessQt.cpp:47
> +    // Disable runtime enabled features that has no WebKit2 implementation yet.

s/has/have/

> WebKit2/WebProcess/qt/WebProcessQt.cpp:53
> +    WebCore::RntimeEnabledFeatures::setSpeechInputEnabled(false);

s/Rntime/Runtime/

[Balazs Kelemen]

Committed in http://trac.webkit.org/changeset/73876.

[Csaba Osztrogonác]

(In reply to comment #3)
> Committed in http://trac.webkit.org/changeset/73876.

Thx for the fix.

[Balazs Kelemen]

(In reply to comment #4)
> (In reply to comment #3)
> > Committed in http://trac.webkit.org/changeset/73876.
> 
> Thx for the fix.

It's an honor to serve you!