Bug 50891 - [GTK] Add API to enable/disable plugins at runtime
Summary: [GTK] Add API to enable/disable plugins at runtime
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-12 05:45 PST by Xan Lopez
Modified: 2010-12-13 11:30 PST (History)
2 users (show)

See Also:

Attachments
pluginenable.diff (8.29 KB, patch)
2010-12-12 05:46 PST, Xan Lopez 		no flags Details | Formatted Diff | Diff
pluginenable.diff (8.28 KB, patch)
2010-12-12 06:26 PST, Xan Lopez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2010-12-12 05:45:06 PST 
Useful for about:plugins and to blacklist certain types of plugins.
Comment 1 Xan Lopez 2010-12-12 05:46:58 PST 
Created attachment 76323 [details]
pluginenable.diff
Comment 2 WebKit Review Bot 2010-12-12 05:48:28 PST 
Attachment 76323 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKit/gtk/ChangeLog', u'WebKit/gtk/tests/testwebplugindatabase.c', u'WebKit/gtk/webkit/webkitwebplugin.cpp', u'WebKit/gtk/webkit/webkitwebplugin.h']" exit_code: 1
WebKit/gtk/webkit/webkitwebplugin.cpp:71:  Missing space before ( in switch(  [whitespace/parens] [5]
WebKit/gtk/webkit/webkitwebplugin.cpp:84:  Missing space before ( in switch(  [whitespace/parens] [5]
WebKit/gtk/webkit/webkitwebplugin.cpp:103:  Extra space before ( in function call  [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "WebKit/gtk/tests/testwebplugindatabase.c"
WebKit/gtk/webkit/webkitwebplugin.h:83:  Extra space before ( in function call  [whitespace/parens] [4]
WebKit/gtk/webkit/webkitwebplugin.h:86:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 5 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Xan Lopez 2010-12-12 06:26:08 PST 
Created attachment 76325 [details]
pluginenable.diff
Comment 4 WebKit Review Bot 2010-12-12 06:28:22 PST 
Attachment 76325 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKit/gtk/ChangeLog', u'WebKit/gtk/tests/testwebplugindatabase.c', u'WebKit/gtk/webkit/webkitwebplugin.cpp', u'WebKit/gtk/webkit/webkitwebplugin.h']" exit_code: 1
WARNING: File exempt from style guide. Skipping: "WebKit/gtk/tests/testwebplugindatabase.c"
WebKit/gtk/webkit/webkitwebplugin.h:83:  Extra space before ( in function call  [whitespace/parens] [4]
WebKit/gtk/webkit/webkitwebplugin.h:86:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Martin Robinson 2010-12-13 10:37:38 PST 
Comment on attachment 76325 [details]
pluginenable.diff

View in context: https://bugs.webkit.org/attachment.cgi?id=76325&action=review

Great stuff. Please fix the tiny style nits below before landing.

> WebKit/gtk/webkit/webkitwebplugin.cpp:67
> +static void webkit_web_plugin_get_property(GObject* object, guint prop_id, GValue* value, GParamSpec* pspec)

Should be propertyId and paramSpec here.

> WebKit/gtk/webkit/webkitwebplugin.cpp:80
> +static void webkit_web_plugin_set_property(GObject* object, guint prop_id, const GValue* value, GParamSpec *pspec)

Same here and the asterisk on pspec should be with GParamSpec.
Comment 6 Xan Lopez 2010-12-13 11:29:54 PST 
Comment on attachment 76325 [details]
pluginenable.diff

Landed in r73936.
Comment 7 Xan Lopez 2010-12-13 11:30:25 PST 
Closing.