Bug 50877 – Web Inspector: Make inspector on Windows show and be usable in WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Brian Weinstein]

Web Inspector: Make inspector on Windows show and be usable in WebKit2

<rdar://problem/8738987>

[Brian Weinstein]

Created attachment 76309 [details]
[PATCH] Fix

[WebKit Review Bot]

Attachment 76309 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/UIProcess/WebInspectorProxy.cpp', u'WebKit2/UIProcess/WebInspectorProxy.h', u'WebKit2/UIProcess/win/WebInspectorProxyWin.cpp']" exit_code: 1
WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:89:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 76309 [details]
[PATCH] Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=76309&action=review

> WebKit2/UIProcess/WebInspectorProxy.h:149
> +    WKViewRef m_inspectorView;

I think storing a RefPtr<WebView> here might make things a bit nicer.

> WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:100
> +        case WM_SIZE:
> +            lResult = onSizeEvent(hWnd, message, wParam, lParam, handled);
> +            break;
> +        case WM_GETMINMAXINFO:
> +            lResult = onMinMaxInfoEvent(hWnd, message, wParam, lParam, handled);
> +            break;
> +        case WM_CLOSE:
> +            lResult = onCloseEvent(hWnd, message, wParam, lParam, handled);
> +            break;
> +        default:
> +            handled = false;
> +            break;

This should be un-indented.

> WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:176
> +    CFStringRef urlStringRef = ::CFURLGetString(htmlURLRef.get());

We traditionally do not use the ::prefix on CF function calls.

[Brian Weinstein]

Comment on attachment 76309 [details]
[PATCH] Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=76309&action=review

>> WebKit2/UIProcess/WebInspectorProxy.h:149
>> +    WKViewRef m_inspectorView;
> 
> I think storing a RefPtr<WebView> here might make things a bit nicer.

I was getting some strange errors when trying to make it a RefPtr<WebView> (errors from of PassRefPtr), but was able to make this a raw pointer, which did make the code a lot cleaner, and was able to remove calls to the WKView* functions and replace them with calls to functions on the WebView.

>> WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:100
>> +            break;
> 
> This should be un-indented.

Fixed.

>> WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:176
>> +    CFStringRef urlStringRef = ::CFURLGetString(htmlURLRef.get());
> 
> We traditionally do not use the ::prefix on CF function calls.

Removed (and got rid of the local variable altogether.

[Brian Weinstein]

Landed in r73877.