Bug 50871 - enumeration value ‘ResponseTypeArrayBuffer’ not handled in switch
Summary: enumeration value ‘ResponseTypeArrayBuffer’ not handled in switch
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Trivial
Assignee: Nobody
Depends on:
Reported: 2010-12-11 06:19 PST by Joone Hur
Modified: 2010-12-11 10:21 PST (History)
4 users (show)

See Also:

Proposed Patch (1.47 KB, patch)
2010-12-11 06:38 PST, Joone Hur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joone Hur 2010-12-11 06:19:14 PST
There is a waring during building JavaScriptCore as follow,

  CXX    WebCore/bindings/js/libwebkitgtk_1_0_la-JSXMLHttpRequestCustom.lo
../../WebCore/bindings/js/JSXMLHttpRequestCustom.cpp: In member function ‘JSC::JSValue WebCore::JSXMLHttpRequest::response(JSC::ExecState*) const’:
../../WebCore/bindings/js/JSXMLHttpRequestCustom.cpp:160: warning: enumeration value ‘ResponseTypeArrayBuffer’ not handled in switch
Comment 1 Joone Hur 2010-12-11 06:38:44 PST
Created attachment 76306 [details]
Proposed Patch

It fixes this warning.
Comment 2 Alexey Proskuryakov 2010-12-11 09:39:39 PST
Comment on attachment 76306 [details]
Proposed Patch

+        return jsUndefined();

I'd also put an ASSERT_NOT_REACHED() there.

As the spec matures, we'll need to re-check what's done to unsupported values in various cases.
Comment 3 WebKit Commit Bot 2010-12-11 10:19:48 PST
The commit-queue encountered the following flaky tests while processing attachment 76306 [details]:

compositing/reflections/animation-inside-reflection.html bug 50875 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2010-12-11 10:21:03 PST
Comment on attachment 76306 [details]
Proposed Patch

Clearing flags on attachment: 76306

Committed r73860: <http://trac.webkit.org/changeset/73860>
Comment 5 WebKit Commit Bot 2010-12-11 10:21:09 PST
All reviewed patches have been landed.  Closing bug.