Bug 50871 – enumeration value ‘ResponseTypeArrayBuffer’ not handled in switch

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Joone Hur]

There is a waring during building JavaScriptCore as follow,

  CXX    WebCore/bindings/js/libwebkitgtk_1_0_la-JSXMLHttpRequestCustom.lo
../../WebCore/bindings/js/JSXMLHttpRequestCustom.cpp: In member function ‘JSC::JSValue WebCore::JSXMLHttpRequest::response(JSC::ExecState*) const’:
../../WebCore/bindings/js/JSXMLHttpRequestCustom.cpp:160: warning: enumeration value ‘ResponseTypeArrayBuffer’ not handled in switch

[Joone Hur]

Created attachment 76306 [details]
Proposed Patch

It fixes this warning.

[Alexey Proskuryakov]

Comment on attachment 76306 [details]
Proposed Patch

+#else
+        return jsUndefined();

I'd also put an ASSERT_NOT_REACHED() there.

As the spec matures, we'll need to re-check what's done to unsupported values in various cases.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 76306 [details]:

compositing/reflections/animation-inside-reflection.html bug 50875 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 76306 [details]
Proposed Patch

Clearing flags on attachment: 76306

Committed r73860: <http://trac.webkit.org/changeset/73860>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.