The branch that checks for a shadow requirement in StillImage::draw() is executed when drawing a canvas onto a canvas with ctx1.drawImage(canvas2, x, y). The current implementation supports solid shadows only. And if transformations are present, the offset gets transformed as well. Thus, ContextShadow must be used instead in order to support blur and correct offset transformations.
Created attachment 76268 [details] Patch
Comment on attachment 76268 [details] Patch LGTM. Assuming your test case failed before this change.
Comment on attachment 76268 [details] Patch Clearing flags on attachment: 76268 Committed r73889: <http://trac.webkit.org/changeset/73889>
All reviewed patches have been landed. Closing bug.
pfeldman seems to believe this caused failures on cr win/linux: http://code.google.com/p/chromium/issues/detail?id=66683 That seems unlikely/impossible.
(In reply to comment #5) > pfeldman seems to believe this caused failures on cr win/linux: > http://code.google.com/p/chromium/issues/detail?id=66683 > That seems unlikely/impossible. Well, the new test introduced with this commit does not pass on chromium. Why unlikely/impossible? Please follow the link to find the failure details: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=canvas-draw-canvas-on-canvas-shadow.html Click "Show results" link and also click the rightmost vertical red bar in the test timeline to see the commit that caused the regression. It this case it is http://trac.webkit.org/changeset/73889 that you reviewed.