WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
50844
Implement Download::start() and Download::startWithHandle() on WebKit2 (Windows)
https://bugs.webkit.org/show_bug.cgi?id=50844
Summary
Implement Download::start() and Download::startWithHandle() on WebKit2 (Windows)
Ada Chan
Reported
2010-12-10 14:24:13 PST
Implement Download::start() and Download::startWithHandle() on WebKit2 on Windows.
Attachments
Patch
(9.63 KB, patch)
2010-12-10 14:37 PST
,
Ada Chan
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ada Chan
Comment 1
2010-12-10 14:37:06 PST
Created
attachment 76264
[details]
Patch
Anders Carlsson
Comment 2
2010-12-10 14:41:30 PST
Comment on
attachment 76264
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=76264&action=review
> WebKit2/WebProcess/Downloads/cf/DownloadCFNet.cpp:122 > + CFRetain(request);
Please add a comment here - "CFNetwork requires us to return a retained request" or something.
> WebKit2/WebProcess/Downloads/cf/DownloadCFNet.cpp:158 > + if (!destination.isNull()) {
Could just do an early return here.
Ada Chan
Comment 3
2010-12-10 15:00:37 PST
Thanks Anders! I have addressed your feedback and checked in:
http://trac.webkit.org/changeset/73807
WebKit Review Bot
Comment 4
2010-12-10 15:17:39 PST
http://trac.webkit.org/changeset/73807
might have broken SnowLeopard Intel Release (Build)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug