Bug 50844 - Implement Download::start() and Download::startWithHandle() on WebKit2 (Windows)
Summary: Implement Download::start() and Download::startWithHandle() on WebKit2 (Windows)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Ada Chan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-10 14:24 PST by Ada Chan
Modified: 2010-12-10 15:17 PST (History)
4 users (show)

See Also:

Attachments
Patch (9.63 KB, patch)
2010-12-10 14:37 PST, Ada Chan 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2010-12-10 14:24:13 PST 
Implement Download::start() and Download::startWithHandle() on WebKit2 on Windows.
Comment 1 Ada Chan 2010-12-10 14:37:06 PST 
Created attachment 76264 [details]
Patch
Comment 2 Anders Carlsson 2010-12-10 14:41:30 PST 
Comment on attachment 76264 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76264&action=review

> WebKit2/WebProcess/Downloads/cf/DownloadCFNet.cpp:122
> +    CFRetain(request);

Please add a comment here - "CFNetwork requires us to return a retained request" or something.

> WebKit2/WebProcess/Downloads/cf/DownloadCFNet.cpp:158
> +    if (!destination.isNull()) {

Could just do an early return here.
Comment 3 Ada Chan 2010-12-10 15:00:37 PST 
Thanks Anders!

I have addressed your feedback and checked in: http://trac.webkit.org/changeset/73807
Comment 4 WebKit Review Bot 2010-12-10 15:17:39 PST 
http://trac.webkit.org/changeset/73807 might have broken SnowLeopard Intel Release (Build)