WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
50842
Shader::loadShader() must initialize variable passed to getShaderiv
https://bugs.webkit.org/show_bug.cgi?id=50842
Summary
Shader::loadShader() must initialize variable passed to getShaderiv
Vincent Scheib
Reported
2010-12-10 13:56:24 PST
Shader::loadShader() must initialize variable passed to getShaderiv
Attachments
Patch
(1.39 KB, patch)
2010-12-10 13:57 PST
,
Vincent Scheib
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Vincent Scheib
Comment 1
2010-12-10 13:57:41 PST
Created
attachment 76254
[details]
Patch
Vincent Scheib
Comment 2
2010-12-10 14:01:08 PST
Looks like recent additions of debug check logic are now warning us of uninitialized variables passed to getter functions. E.g. this output on a debug build: gpu/command_buffer/client/../client/gles2_c_lib_autogen.h(369): GPU_DCHECK(params && (params[0] == static_cast<GLint>(0) || params[0] == static_cast<GLint>(-1)) (0)) failed.
James Robinson
Comment 3
2010-12-10 14:02:55 PST
Comment on
attachment 76254
[details]
Patch Good catch! R=me
WebKit Review Bot
Comment 4
2010-12-10 19:00:56 PST
Comment on
attachment 76254
[details]
Patch Clearing flags on attachment: 76254 Committed
r73832
: <
http://trac.webkit.org/changeset/73832
>
WebKit Review Bot
Comment 5
2010-12-10 19:01:01 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug