Bug 50841 - [Chromium] canvas/philip/tests/2d.missingargs.html hangs on Snow Leopard
Summary: [Chromium] canvas/philip/tests/2d.missingargs.html hangs on Snow Leopard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-10 13:33 PST by Mihai Parparita
Modified: 2010-12-13 10:16 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.25 KB, patch)
2010-12-10 13:38 PST, Mihai Parparita
no flags Details | Formatted Diff | Diff
Patch for landing (3.30 KB, patch)
2010-12-13 09:31 PST, Mihai Parparita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-12-10 13:33:46 PST
[Chromium] canvas/philip/tests/2d.missingargs.html hangs on Snow Leopard
Comment 1 Mihai Parparita 2010-12-10 13:38:30 PST
Created attachment 76250 [details]
Patch
Comment 2 WebKit Review Bot 2010-12-10 19:40:13 PST
Comment on attachment 76250 [details]
Patch

Rejecting attachment 76250 [details] from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2
Last 500 characters of output:
..............
fast/borders .............................................................
fast/box-shadow .....
fast/box-sizing ....
fast/canvas ......................................................................................................................
fast/canvas/strokeText-missing-args.html -> failed

Exiting early after 1 failures. 6172 tests run.
106.05s total testing time

6171 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
4 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/6891046
Comment 3 Mihai Parparita 2010-12-13 09:31:49 PST
Created attachment 76393 [details]
Patch for landing
Comment 4 Mihai Parparita 2010-12-13 09:34:26 PST
(In reply to comment #2)
> fast/canvas/strokeText-missing-args.html -> failed

I had only tested this with V8, with the JSC bindings strokeText() (with no arguments) throws an exception (which is fine too). I added a try/catch for that in the test.
Comment 5 WebKit Review Bot 2010-12-13 10:15:56 PST
Comment on attachment 76393 [details]
Patch for landing

Clearing flags on attachment: 76393

Committed r73926: <http://trac.webkit.org/changeset/73926>
Comment 6 WebKit Review Bot 2010-12-13 10:16:01 PST
All reviewed patches have been landed.  Closing bug.