Bug 50836 - Move open and showModalDialog implementations from bindings into DOM class DOMWindow
Summary: Move open and showModalDialog implementations from bindings into DOM class DO...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-10 12:08 PST by Darin Adler
Modified: 2010-12-10 18:20 PST (History)
3 users (show)

See Also:


Attachments
Patch (54.53 KB, patch)
2010-12-10 12:20 PST, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (54.53 KB, patch)
2010-12-10 14:19 PST, Darin Adler
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2010-12-10 12:08:41 PST
Move open and showModalDialog implementations from bindings into DOM class DOMWindow
Comment 1 Darin Adler 2010-12-10 12:20:55 PST
Created attachment 76234 [details]
Patch
Comment 2 WebKit Review Bot 2010-12-10 12:24:42 PST
Attachment 76234 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/bindings/js/JSDOMWindowCustom.cpp', u'WebCore/page/DOMWindow.cpp', u'WebCore/page/DOMWindow.h', u'WebCore/page/WindowFeatures.cpp', u'WebCore/page/WindowFeatures.h']" exit_code: 1
WebCore/page/WindowFeatures.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebCore/page/WindowFeatures.cpp:228:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2010-12-10 12:28:56 PST
Attachment 76234 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6926037
Comment 4 Build Bot 2010-12-10 13:19:27 PST
Attachment 76234 [details] did not build on win:
Build output: http://queues.webkit.org/results/6925046
Comment 5 Darin Adler 2010-12-10 14:19:37 PST
Created attachment 76259 [details]
Patch
Comment 6 WebKit Review Bot 2010-12-10 14:21:54 PST
Attachment 76259 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/bindings/js/JSDOMWindowCustom.cpp', u'WebCore/page/DOMWindow.cpp', u'WebCore/page/DOMWindow.h', u'WebCore/page/WindowFeatures.cpp', u'WebCore/page/WindowFeatures.h']" exit_code: 1
WebCore/page/WindowFeatures.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebCore/page/WindowFeatures.cpp:228:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Darin Adler 2010-12-10 18:20:25 PST
Committed r73829: <http://trac.webkit.org/changeset/73829>