Bug 50830 - Use FileSystem::remove when cleaning up http lock files
Summary: Use FileSystem::remove when cleaning up http lock files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-10 10:43 PST by Tony Chang
Modified: 2010-12-10 12:23 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.33 KB, patch)
2010-12-10 10:46 PST, Tony Chang 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-12-10 10:43:31 PST 
Use FileSystem::remove when cleaning up http lock files
Comment 1 Tony Chang 2010-12-10 10:46:01 PST 
Created attachment 76220 [details]
Patch
Comment 2 Tony Chang 2010-12-10 10:47:24 PST 
Here's a more precise description of the problem we were seeing on Windows:

When a process is killed, Windows may hold on to the files for a short time after the process has ended.  It reminds me of how tcp ports may still be used for a short while after the process using them has been killed.
Comment 3 Tony Chang 2010-12-10 10:48:13 PST 
(In reply to comment #2)
> Here's a more precise description of the problem we were seeing on Windows:
> 
> When a process is killed, Windows may hold on to the files for a short time after the process has ended.  It reminds me of how tcp ports may still be used for a short while after the process using them has been killed.

Oh, so it's not clear that we want to apply FileSystem.remove everywhere, but I guess it would be harmless to do so.  Maybe we should rename it to something more specific for this specific case?
Comment 4 Eric Seidel (no email) 2010-12-10 12:18:16 PST 
Generally using Filesysem function is better than os. because they're more easily mockable.
Comment 5 Eric Seidel (no email) 2010-12-10 12:18:43 PST 
Comment on attachment 76220 [details]
Patch

OK.
Comment 6 Tony Chang 2010-12-10 12:23:32 PST 
Committed r73769: <http://trac.webkit.org/changeset/73769>