Bug 50828 - [v8] More CSS wrappers GC work: keep document's style sheets, style sheet and css rule lists' items in proper object groups
Summary: [v8] More CSS wrappers GC work: keep document's style sheets, style sheet and...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: anton muhin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-10 10:26 PST by anton muhin
Modified: 2010-12-13 05:34 PST (History)
4 users (show)

See Also:


Attachments
Patch (21.69 KB, patch)
2010-12-10 12:34 PST, anton muhin
no flags Details | Formatted Diff | Diff
Patch (18.35 KB, patch)
2010-12-13 04:03 PST, anton muhin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description anton muhin 2010-12-10 10:26:39 PST
[v8] More CSS wrappers GC work: keep document's style sheets, style sheet and css rule lists' items in proper object groups
Comment 1 anton muhin 2010-12-10 12:34:20 PST
Created attachment 76238 [details]
Patch
Comment 2 WebKit Review Bot 2010-12-10 12:37:20 PST
Attachment 76238 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/dom/StyleSheet/gc-rule-children-wrappers-expected.txt', u'LayoutTests/fast/dom/StyleSheet/gc-rule-children-wrappers.html', u'WebCore/ChangeLog', u'WebCore/bindings/v8/DOMData.h', u'WebCore/bindings/v8/DOMDataStore.h', u'WebCore/bindings/v8/V8DOMMap.cpp', u'WebCore/bindings/v8/V8DOMMap.h', u'WebCore/bindings/v8/V8GCController.cpp']" exit_code: 1
WebCore/bindings/v8/V8DOMMap.h:39:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Barth 2010-12-10 13:53:35 PST
Comment on attachment 76238 [details]
Patch

Thanks for working on these bugs!  I caused some of these problems but I couldn't figure out how to fix them.
Comment 4 Alexey Proskuryakov 2010-12-10 21:52:56 PST
Are you positive that the new subtests belong to gc-rule-children-wrappers? Are they about rule children wrappers?

Please don't land unless the answer is yes.
Comment 5 Adam Barth 2010-12-10 22:31:26 PST
I'm not sure I understand your question.  If you'd prefer the new tests to be in a separate file, we can certainly do that.
Comment 6 Alexey Proskuryakov 2010-12-10 23:13:13 PST
I didn't try very hard to understand what the new tests do - but yes, it seems like they do not test "rule children wrappers" behavior, and need to be in a different file.
Comment 7 anton muhin 2010-12-13 02:30:18 PST
Adam, Alexey, thanks a lot for comments.

I'll revert my changes to layout tests for now and would add another layout test later.

(In reply to comment #6)
> I didn't try very hard to understand what the new tests do - but yes, it seems like they do not test "rule children wrappers" behavior, and need to be in a different file.
Comment 8 anton muhin 2010-12-13 04:03:25 PST
Created attachment 76366 [details]
Patch
Comment 9 WebKit Review Bot 2010-12-13 04:05:45 PST
Attachment 76366 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/bindings/v8/DOMData.h', u'WebCore/bindings/v8/DOMDataStore.h', u'WebCore/bindings/v8/V8DOMMap.cpp', u'WebCore/bindings/v8/V8DOMMap.h', u'WebCore/bindings/v8/V8GCController.cpp']" exit_code: 1
WebCore/bindings/v8/V8DOMMap.h:39:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Pavel Feldman 2010-12-13 04:10:31 PST
Comment on attachment 76366 [details]
Patch

Rubber stamping revert.
Comment 11 WebKit Review Bot 2010-12-13 05:34:21 PST
Comment on attachment 76366 [details]
Patch

Clearing flags on attachment: 76366

Committed r73907: <http://trac.webkit.org/changeset/73907>
Comment 12 WebKit Review Bot 2010-12-13 05:34:27 PST
All reviewed patches have been landed.  Closing bug.