WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
50824
When the build is broken on Windows, it isn't clear what project is to blame
https://bugs.webkit.org/show_bug.cgi?id=50824
Summary
When the build is broken on Windows, it isn't clear what project is to blame
Adam Roben (:aroben)
Reported
2010-12-10 09:34:31 PST
When a project fails to build on Windows, all subsequent projects fail with this mysterious output: Preforming Pre-Build Event... Project : error PRJ0002 : Error result 1 returned from 'C:\WINDOWS\system32\cmd.exe'. We should make this output tell you what prior project failed to build.
Attachments
Add attachment
proposed patch, testcase, etc.
Steve Falkenburg
Comment 1
2010-12-10 10:24:22 PST
Another possible fix (for the bots) would be to have build-webkit build each vcproj individually rather than relying on a sln to build all of them. Then we could check the exit code after each build and not kick off the subsequent build when one failed. The downside of this approach would be that it is a little more maintenance work since we'd need to keep the project list in build-webkit up-to-date.
Adam Roben (:aroben)
Comment 2
2010-12-10 10:44:37 PST
(In reply to
comment #1
)
> Another possible fix (for the bots) would be to have build-webkit build each vcproj individually rather than relying on a sln to build all of them. > > Then we could check the exit code after each build and not kick off the subsequent build when one failed. > > The downside of this approach would be that it is a little more maintenance work since we'd need to keep the project list in build-webkit up-to-date.
That's true, that could make the bot output even clearer. But we could probably achieve the same effect by having build-webkit find the first failing project for you and print it at the end. Even if we don't do either of those things, I think having output like "JavaScriptCore failed to build. Aborting build of $(ProjectName)." would be pretty clear.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug