Bug 50818 - Use enums instead of booleans in ImageSource/ImageDecoder constructors
Summary: Use enums instead of booleans in ImageSource/ImageDecoder constructors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Zhenyao Mo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-10 08:10 PST by Zhenyao Mo
Modified: 2010-12-10 17:19 PST (History)
5 users (show)

See Also:

Attachments
Patch (24.61 KB, patch)
2010-12-10 08:23 PST, Zhenyao Mo 		no flags Details | Formatted Diff | Diff
Patch (24.61 KB, patch)
2010-12-10 08:56 PST, Zhenyao Mo 		abarth: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zhenyao Mo 2010-12-10 08:10:10 PST 
As Adam called it, it's my debt.  Paying it now...
Comment 1 Zhenyao Mo 2010-12-10 08:23:01 PST 
Created attachment 76203 [details]
Patch
Comment 2 WebKit Review Bot 2010-12-10 08:48:47 PST 
Attachment 76203 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7000031
Comment 3 Zhenyao Mo 2010-12-10 08:56:24 PST 
Created attachment 76208 [details]
Patch
Comment 4 Adam Barth 2010-12-10 13:15:37 PST 
Comment on attachment 76208 [details]
Patch

Thanks.  I appreciate it.
Comment 5 WebKit Commit Bot 2010-12-10 17:07:53 PST 
Comment on attachment 76208 [details]
Patch

Rejecting attachment 76208 [details] from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2
Last 500 characters of output:
CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/JSGeolocationCustom.o /Projects/CommitQueue/WebCore/bindings/js/JSGeolocationCustom.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
	CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/JSHashChangeEvent.o /Projects/CommitQueue/WebKitBuild/Debug/DerivedSources/WebCore/JSHashChangeEvent.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
(215 failures)


Full output: http://queues.webkit.org/results/6909038
Comment 6 Zhenyao Mo 2010-12-10 17:19:46 PST 
Committed r73819: <http://trac.webkit.org/changeset/73819>