RESOLVED FIXED50813
Web Inspector: creating conditional breakpoint doesn't work if breakpoint moves 
https://bugs.webkit.org/show_bug.cgi?id=50813
Summary Web Inspector: creating conditional breakpoint doesn't work if breakpoint moves
Pavel Podivilov
Reported 2010-12-10 06:40:26 PST
1. Right click on a script line with comment. 2. Choose "Add Conditional Breakpoint". 3. Breakpoint is moved but condition popup doesn't, breakpoint is created without condition.
Attachments
Patch. (10.53 KB, patch)
2010-12-10 06:41 PST, Pavel Podivilov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2010-12-10 06:41:12 PST
Created attachment 76188 [details] Patch.
Yury Semikhatsky
Comment 2 2010-12-20 05:38:14 PST
Comment on attachment 76188 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=76188&action=review > WebCore/inspector/front-end/SourceFrame.js:452 > + lineNumber -= 1; Why do you need this? It should be extracted into a method with descriptive name.
Pavel Podivilov
Comment 3 2010-12-20 08:44:27 PST
(In reply to comment #2) > (From update of attachment 76188 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=76188&action=review > > > WebCore/inspector/front-end/SourceFrame.js:452 > > + lineNumber -= 1; > > Why do you need this? It should be extracted into a method with descriptive name. This is because we use zero-based line numbers in text viewer. We may add addDecoration/removeDecoration methods to SourceFrame and extract it there.
Pavel Podivilov
Comment 4 2010-12-20 08:45:09 PST
Committed r74350: <http://trac.webkit.org/changeset/74350>
Note You need to log in before you can comment on or make changes to this bug.