Bug 50802 - Refactor by merging tests for ValidityState (patternMismatch and customError)
Summary: Refactor by merging tests for ValidityState (patternMismatch and customError)
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 50617
  Show dependency treegraph
Reported: 2010-12-09 23:17 PST by Dai Mikurube
Modified: 2010-12-10 03:42 PST (History)
4 users (show)

See Also:

Patch (44.76 KB, patch)
2010-12-09 23:42 PST, Dai Mikurube
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dai Mikurube 2010-12-09 23:17:22 PST
- fast/forms/ValidityState-patternMismatch-00?.html into fast/forms/ValidityState-patternMismatch.html.
- fast/forms/ValidityState-customError-00?.html into fast/forms/ValidityState-customError.html.
Comment 1 Dai Mikurube 2010-12-09 23:42:55 PST
Created attachment 76167 [details]
Comment 2 Kent Tamura 2010-12-09 23:48:47 PST
Comment on attachment 76167 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=76167&action=review


> LayoutTests/fast/forms/ValidityState-patternMismatch-expected.txt:6
> +PASS patternMismatchFor("simple") is false

The result readability is better than the original.
It would be much better if pattern and value are printed.
Comment 3 WebKit Review Bot 2010-12-10 02:46:50 PST
Comment on attachment 76167 [details]

Rejecting attachment 76167 [details] from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--non-interactive', 76167]" exit_code: 2
Last 500 characters of output:
led to merge in the changes.
Patch failed at 0001 [Qt] Make sure we send the response before any data.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at WebKitTools/Scripts/update-webkit line 132.

Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2

Full output: http://queues.webkit.org/results/6989034
Comment 4 Eric Seidel (no email) 2010-12-10 02:51:19 PST
Adam's start-commit-queue.sh wrapper script was missing a git rebase --abort call, so I added it.

Sorry for the noise.
Comment 5 WebKit Review Bot 2010-12-10 03:42:29 PST
Comment on attachment 76167 [details]

Clearing flags on attachment: 76167

Committed r73715: <http://trac.webkit.org/changeset/73715>
Comment 6 WebKit Review Bot 2010-12-10 03:42:35 PST
All reviewed patches have been landed.  Closing bug.