Bug 50768 - Add a basic implementation of PDF support on Mac
Summary: Add a basic implementation of PDF support on Mac
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
Depends on:
Reported: 2010-12-09 10:44 PST by Anders Carlsson
Modified: 2010-12-09 11:01 PST (History)
1 user (show)

See Also:

Patch (18.39 KB, patch)
2010-12-09 10:49 PST, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-12-09 10:44:03 PST
Add a basic implementation of PDF support on Mac
Comment 1 Anders Carlsson 2010-12-09 10:49:49 PST
Created attachment 76094 [details]
Comment 2 WebKit Review Bot 2010-12-09 10:52:53 PST
Attachment 76094 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/UIProcess/API/mac/PDFViewController.h', u'WebKit2/UIProcess/API/mac/PDFViewController.mm', u'WebKit2/UIProcess/API/mac/PageClientImpl.mm', u'WebKit2/UIProcess/API/mac/WKView.mm', u'WebKit2/UIProcess/API/mac/WKViewInternal.h', u'WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
WebKit2/UIProcess/API/mac/PDFViewController.h:39:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 7 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-12-09 10:53:03 PST
Comment on attachment 76094 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=76094&action=review

> WebKit2/UIProcess/API/mac/PDFViewController.h:48
> +    static PassOwnPtr<PDFViewController> create(WKView *wkView);

Parameter name is not needed.

> WebKit2/UIProcess/API/mac/PDFViewController.h:67
> +}

We usually put // namespace WebKit here.

> WebKit2/UIProcess/API/mac/WKView.mm:1001
> +- (void)_setPageHasCustomRepresentation:(BOOL)pageHasCustomRepresentation {

{ should be on the next line.

> WebKit2/UIProcess/API/mac/WKView.mm:1008
> +- (void)_didFinishLoadingDataForCustomRepresentation:(const CoreIPC::DataReference&)dataReference {

Same here.
Comment 4 Anders Carlsson 2010-12-09 11:01:05 PST
Committed r73630: <http://trac.webkit.org/changeset/73630>