Bug 50768 – Add a basic implementation of PDF support on Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Add a basic implementation of PDF support on Mac

[Anders Carlsson]

Created attachment 76094 [details]
Patch

[WebKit Review Bot]

Attachment 76094 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/UIProcess/API/mac/PDFViewController.h', u'WebKit2/UIProcess/API/mac/PDFViewController.mm', u'WebKit2/UIProcess/API/mac/PageClientImpl.mm', u'WebKit2/UIProcess/API/mac/WKView.mm', u'WebKit2/UIProcess/API/mac/WKViewInternal.h', u'WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
WebKit2/UIProcess/API/mac/PDFViewController.h:39:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 76094 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76094&action=review

> WebKit2/UIProcess/API/mac/PDFViewController.h:48
> +    static PassOwnPtr<PDFViewController> create(WKView *wkView);

Parameter name is not needed.

> WebKit2/UIProcess/API/mac/PDFViewController.h:67
> +}

We usually put // namespace WebKit here.

> WebKit2/UIProcess/API/mac/WKView.mm:1001
> +- (void)_setPageHasCustomRepresentation:(BOOL)pageHasCustomRepresentation {

{ should be on the next line.

> WebKit2/UIProcess/API/mac/WKView.mm:1008
> +- (void)_didFinishLoadingDataForCustomRepresentation:(const CoreIPC::DataReference&)dataReference {

Same here.

[Anders Carlsson]

Committed r73630: <http://trac.webkit.org/changeset/73630>