Bug 50760 - [Qt] It's possible to send data before the response when we handle ignored errors.
Summary: [Qt] It's possible to send data before the response when we handle ignored er...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
Keywords: Qt, QtTriaged
Depends on:
Reported: 2010-12-09 07:16 PST by Jocelyn Turcotte
Modified: 2010-12-10 11:46 PST (History)
5 users (show)

See Also:

Patch (3.72 KB, patch)
2010-12-09 07:23 PST, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff
Patch v2 (fixes compile error) (3.73 KB, patch)
2010-12-09 08:07 PST, Jocelyn Turcotte
kenneth: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2010-12-09 07:16:34 PST
I saw times where sendResponseIfNeeded called by forwardData woudln't send the response even if data was available since m_responseDataSent woudln't be set yet.
Comment 1 Jocelyn Turcotte 2010-12-09 07:23:25 PST
Created attachment 76060 [details]
Comment 2 Early Warning System Bot 2010-12-09 07:35:49 PST
Attachment 76060 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6919018
Comment 3 Jocelyn Turcotte 2010-12-09 08:07:13 PST
Created attachment 76066 [details]
Patch v2 (fixes compile error)
Comment 4 WebKit Commit Bot 2010-12-09 22:24:12 PST
Comment on attachment 76066 [details]
Patch v2 (fixes compile error)

Rejecting patch 76066 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1
ERROR: Working directory has local commits, pass --force-clean to continue.

Full output: http://queues.webkit.org/results/6924028
Comment 5 WebKit Commit Bot 2010-12-09 22:24:24 PST
The commit-queue encountered the following flaky tests while processing attachment 76066 [details]:


Please file bugs against the tests.  These tests were authored by abarth@webkit.org and mitz@webkit.org.  The commit-queue is continuing to process your patch.
Comment 6 Jocelyn Turcotte 2010-12-10 02:44:13 PST
Committed r73707: <http://trac.webkit.org/changeset/73707>
Comment 7 WebKit Review Bot 2010-12-10 11:46:03 PST
http://trac.webkit.org/changeset/73707 might have broken GTK Linux 32-bit Debug