Bug 50751 – Change the --multi-load test option to --stress-opt

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Søren Gjesse]

The V8 shell has the option --stress-opt which does multiple loads together with changing JavaScript flags for stressing V8 optimizations. This provides a simpler way for stressing than the --multi-load together with --js-flags holding an array of JavaScript flags. As the stressing is exposed in a V8 API the means stressing can be controlled from a single place.

Therefore when running the WebKit tests with the chromium DumpRenderTree the --stress-opt option should be used as well.

[Søren Gjesse]

Created attachment 76054 [details]
Patch

[WebKit Review Bot]

Attachment 76054 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6919017

[Søren Gjesse]

Created attachment 77811 [details]
Patch

[Tony Chang]

Comment on attachment 77811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77811&action=review

LGTM if you fix the typo mentioned.

> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:92
> +        v8::Testing::SetStressRunType(v8::Testing::kStressTypeOpt);

This should be kStressTypeDepot, right?

[Søren Gjesse]

(In reply to comment #4)
> (From update of attachment 77811 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77811&action=review
> 
> LGTM if you fix the typo mentioned.
> 
> > Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:92
> > +        v8::Testing::SetStressRunType(v8::Testing::kStressTypeOpt);
> 
> This should be kStressTypeDepot, right?

It sure should, good catch.

[Søren Gjesse]

Created attachment 77868 [details]
Patch

[WebKit Review Bot]

Comment on attachment 77868 [details]
Patch

Rejecting attachment 77868 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Tony Chang]

Comment on attachment 77868 [details]
Patch

let me try

[WebKit Commit Bot]

Comment on attachment 77868 [details]
Patch

Clearing flags on attachment: 77868

Committed r75036: <http://trac.webkit.org/changeset/75036>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.