Bug 50751 - Change the --multi-load test option to --stress-opt
Summary: Change the --multi-load test option to --stress-opt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Søren Gjesse
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-09 05:18 PST by Søren Gjesse
Modified: 2011-01-04 18:09 PST (History)
7 users (show)

See Also:

Attachments
Patch (11.67 KB, patch)
2010-12-09 05:41 PST, Søren Gjesse 		no flags Details | Formatted Diff | Diff
Patch (11.55 KB, patch)
2011-01-03 07:46 PST, Søren Gjesse 		no flags Details | Formatted Diff | Diff
Patch (11.56 KB, patch)
2011-01-04 00:23 PST, Søren Gjesse 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Søren Gjesse 2010-12-09 05:18:10 PST 
The V8 shell has the option --stress-opt which does multiple loads together with changing JavaScript flags for stressing V8 optimizations. This provides a simpler way for stressing than the --multi-load together with --js-flags holding an array of JavaScript flags. As the stressing is exposed in a V8 API the means stressing can be controlled from a single place.

Therefore when running the WebKit tests with the chromium DumpRenderTree the --stress-opt option should be used as well.
Comment 1 Søren Gjesse 2010-12-09 05:41:28 PST 
Created attachment 76054 [details]
Patch
Comment 2 WebKit Review Bot 2010-12-09 05:56:23 PST 
Attachment 76054 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/6919017
Comment 3 Søren Gjesse 2011-01-03 07:46:21 PST 
Created attachment 77811 [details]
Patch
Comment 4 Tony Chang 2011-01-03 08:55:24 PST 
Comment on attachment 77811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77811&action=review

LGTM if you fix the typo mentioned.

> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:92
> +        v8::Testing::SetStressRunType(v8::Testing::kStressTypeOpt);

This should be kStressTypeDepot, right?
Comment 5 Søren Gjesse 2011-01-04 00:21:25 PST 
(In reply to comment #4)
> (From update of attachment 77811 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77811&action=review
> 
> LGTM if you fix the typo mentioned.
> 
> > Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:92
> > +        v8::Testing::SetStressRunType(v8::Testing::kStressTypeOpt);
> 
> This should be kStressTypeDepot, right?

It sure should, good catch.
Comment 6 Søren Gjesse 2011-01-04 00:23:33 PST 
Created attachment 77868 [details]
Patch
Comment 7 WebKit Review Bot 2011-01-04 14:19:19 PST 
Comment on attachment 77868 [details]
Patch

Rejecting attachment 77868 [details] from commit-queue.

sgjesse@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 8 Tony Chang 2011-01-04 14:20:33 PST 
Comment on attachment 77868 [details]
Patch

let me try
Comment 9 WebKit Commit Bot 2011-01-04 18:09:44 PST 
Comment on attachment 77868 [details]
Patch

Clearing flags on attachment: 77868

Committed r75036: <http://trac.webkit.org/changeset/75036>
Comment 10 WebKit Commit Bot 2011-01-04 18:09:51 PST 
All reviewed patches have been landed.  Closing bug.