Bug 50750 – [Qt][WK2] Add the QWKContext API class to wrap the WebContext.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jocelyn Turcotte]

[Qt][WK2] Add the QWKContext API class to wrap the WebContext.

[Jocelyn Turcotte]

Created attachment 76048 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 76048 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76048&action=review

> WebKit2/UIProcess/API/qt/qwkcontext.h:36
> +    // Bridge from the C API
> +    QWKContext(WKPageNamespaceRef pageNamespaceRef, QObject* parent = 0);

Do we need this if the namespace is going away anyway?

> WebKit2/UIProcess/API/qt/qwkcontext_p.h:37
> +    RefPtr<WebKit::WebPageNamespace> pageNamespace;
> +

unneeded newspace

[Jocelyn Turcotte]

Created attachment 76175 [details]
Patch v2

(In reply to comment #2)
> (From update of attachment 76048 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=76048&action=review
> 
> > WebKit2/UIProcess/API/qt/qwkcontext.h:36
> > +    // Bridge from the C API
> > +    QWKContext(WKPageNamespaceRef pageNamespaceRef, QObject* parent = 0);
> 
> Do we need this if the namespace is going away anyway?
> 
This namespace is given to us in WebKitTools/WebKitTestRunner/qt/PlatformWebViewQt.cpp.
It shouldn't be public so we might have to find a different way sooner or later.
Having this contstructor in QWKContextPrivate and have a non-public friend factory method kind of trick could do it.

> > WebKit2/UIProcess/API/qt/qwkcontext_p.h:37
> > +    RefPtr<WebKit::WebPageNamespace> pageNamespace;
> > +
> 
> unneeded newspace
Fixed

[WebKit Review Bot]

Comment on attachment 76175 [details]
Patch v2

Clearing flags on attachment: 76175

Committed r73716: <http://trac.webkit.org/changeset/73716>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.