Bug 50743 - [GTK] Fix build with current gtk+
Summary: [GTK] Fix build with current gtk+
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 50563 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-12-09 02:54 PST by Carlos Garcia Campos
Modified: 2010-12-09 03:36 PST (History)
3 users (show)

See Also:

Attachments
Patch to fix the build with gtk3 (1.43 KB, patch)
2010-12-09 02:57 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2010-12-09 02:54:33 PST 
gdk_window_get_geometry() api has changed.
Comment 1 Carlos Garcia Campos 2010-12-09 02:57:31 PST 
Created attachment 76032 [details]
Patch to fix the build with gtk3
Comment 2 WebKit Review Bot 2010-12-09 02:59:34 PST 
Attachment 76032 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/plugins/gtk/gtk2xtbin.c']" exit_code: 1
WebCore/plugins/gtk/gtk2xtbin.c:277:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/plugins/gtk/gtk2xtbin.c:277:  Extra space between gint and x  [whitespace/declaration] [3]
WebCore/plugins/gtk/gtk2xtbin.c:289:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/plugins/gtk/gtk2xtbin.c:291:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gustavo Noronha (kov) 2010-12-09 03:12:19 PST 
Comment on attachment 76032 [details]
Patch to fix the build with gtk3

we are landing a different patch already
Comment 4 Gustavo Noronha (kov) 2010-12-09 03:35:22 PST 
*** Bug 50563 has been marked as a duplicate of this bug. ***
Comment 5 Gustavo Noronha (kov) 2010-12-09 03:36:30 PST 
This was fixed in r73603.