RESOLVED FIXED 50743
[GTK] Fix build with current gtk+ 
https://bugs.webkit.org/show_bug.cgi?id=50743
Summary [GTK] Fix build with current gtk+
Carlos Garcia Campos
Reported 2010-12-09 02:54:33 PST
gdk_window_get_geometry() api has changed.
Attachments
Patch to fix the build with gtk3 (1.43 KB, patch)
2010-12-09 02:57 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2010-12-09 02:57:31 PST
Created attachment 76032 [details] Patch to fix the build with gtk3
WebKit Review Bot
Comment 2 2010-12-09 02:59:34 PST
Attachment 76032 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/plugins/gtk/gtk2xtbin.c']" exit_code: 1 WebCore/plugins/gtk/gtk2xtbin.c:277: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/plugins/gtk/gtk2xtbin.c:277: Extra space between gint and x [whitespace/declaration] [3] WebCore/plugins/gtk/gtk2xtbin.c:289: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebCore/plugins/gtk/gtk2xtbin.c:291: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gustavo Noronha (kov)
Comment 3 2010-12-09 03:12:19 PST
Comment on attachment 76032 [details] Patch to fix the build with gtk3 we are landing a different patch already
Gustavo Noronha (kov)
Comment 4 2010-12-09 03:35:22 PST
*** Bug 50563 has been marked as a duplicate of this bug. ***
Gustavo Noronha (kov)
Comment 5 2010-12-09 03:36:30 PST
This was fixed in r73603.
Note You need to log in before you can comment on or make changes to this bug.