Bug 50741 - [GTK] configure: error out if video is enabled and gstreamer pkg-config check fails
Summary: [GTK] configure: error out if video is enabled and gstreamer pkg-config check...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-09 02:51 PST by Philippe Normand
Modified: 2010-12-09 03:08 PST (History)
0 users

See Also:


Attachments
proposed patch (1.32 KB, patch)
2010-12-09 02:55 PST, Philippe Normand
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-12-09 02:51:23 PST
In the configure.ac PKG_CHECK_MODULES call for gstreamer the action-if-not-found we have is to set $have_gstreamer to "no". The consequence is that in this case the build will fail.

So if HTML5 media is enabled at configure time and if the pkg-config gstreamer check fails the configure script should error out, which is the default action-if-not-found of PKG_CHECK_MODULES.
Comment 1 Philippe Normand 2010-12-09 02:55:38 PST
Created attachment 76030 [details]
proposed patch
Comment 2 Xan Lopez 2010-12-09 03:02:50 PST
Comment on attachment 76030 [details]
proposed patch

r=me
Comment 3 Philippe Normand 2010-12-09 03:08:59 PST
Committed r73600: <http://trac.webkit.org/changeset/73600>