Bug 50739 - [GTK] Add hasSpellingMarker support to the DRT
Summary: [GTK] Add hasSpellingMarker support to the DRT
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on: 50738
  Show dependency treegraph
Reported: 2010-12-09 01:56 PST by Alejandro G. Castro
Modified: 2010-12-14 01:20 PST (History)
2 users (show)

See Also:

Proposed patch (7.77 KB, patch)
2010-12-09 02:56 PST, Alejandro G. Castro
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2010-12-09 01:56:33 PST
We need to add support to hasSpellingMarker in order to make the spelling tests to pass.
Comment 1 Alejandro G. Castro 2010-12-09 02:56:07 PST
Created attachment 76031 [details]
Proposed patch
Comment 2 Martin Robinson 2010-12-09 03:07:06 PST
Comment on attachment 76031 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76031&action=review

> WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:418
> +    return coreFrame->editor()->selectionStartHasSpellingMarkerFor(from, length);

Maybe just core(frame)->... here before landing.

> WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:74
> +    static bool webkitWebFrameSelectionHasSpellingMarker(WebKitWebFrame *frame, gint from, gint length);

Please remove the variable name before landing.
Comment 3 Alejandro G. Castro 2010-12-10 10:20:58 PST
Landed http://trac.webkit.org/changeset/73740