Bug 50726 - Need a way to get a WKBundleFrameRef from JS HTMLIFrameElement
Summary: Need a way to get a WKBundleFrameRef from JS HTMLIFrameElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-08 17:49 PST by Sam Weinig
Modified: 2010-12-09 02:22 PST (History)
3 users (show)

See Also:

Attachments
Patch (8.81 KB, patch)
2010-12-08 17:51 PST, Sam Weinig 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-12-08 17:49:17 PST 
We need a way to get a WKBundleFrameRef from JS HTMLIFrameElement, for traversing a frame tree from JS evading security mechanisms.
Comment 1 Sam Weinig 2010-12-08 17:51:03 PST 
Created attachment 75996 [details]
Patch
Comment 2 Darin Adler 2010-12-08 17:53:39 PST 
Comment on attachment 75996 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75996&action=review

> WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:63
> +    PassRefPtr<WebFrame> copyDocumentFrame();
> +    PassRefPtr<WebFrame> copyHTMLFrameElementContentFrame();
> +    PassRefPtr<WebFrame> copyHTMLIFrameElementContentFrame();

When the return type is a PassRefPtr, I’m not sure it makes all that much sense to use copy naming when there’s no actual copying going on. There’s no need to use the copy rule for naming when you have a smart pointer class involved.
Comment 3 Sam Weinig 2010-12-08 19:27:30 PST 
Fixed in http://trac.webkit.org/changeset/73579.
Comment 4 WebKit Review Bot 2010-12-09 02:22:48 PST 
http://trac.webkit.org/changeset/73579 might have broken GTK Linux 32-bit Release