Bug 50725 - REGRESSION (r72052): “Search” placeholder in MobileMe mail is positioned too high
Summary: REGRESSION (r72052): “Search” placeholder in MobileMe mail is positioned too ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Adele Peterson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-08 17:02 PST by Adele Peterson
Modified: 2010-12-09 02:22 PST (History)
4 users (show)

See Also:


Attachments
patch (34.86 KB, patch)
2010-12-08 17:09 PST, Adele Peterson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adele Peterson 2010-12-08 17:02:10 PST
“Search” placeholder in MobileMe mail is positioned too high
Comment 1 Adele Peterson 2010-12-08 17:09:34 PST
Created attachment 75990 [details]
patch
Comment 2 Adele Peterson 2010-12-08 17:10:39 PST
Comment on attachment 75990 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75990&action=review

> WebCore/rendering/RenderTextControlSingleLine.cpp:1132
> +        return innerRenderer->y();

I hope this isn't too simplistic.
Comment 3 Darin Adler 2010-12-08 17:12:57 PST
Comment on attachment 75990 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75990&action=review

>> WebCore/rendering/RenderTextControlSingleLine.cpp:1132
>> +        return innerRenderer->y();
> 
> I hope this isn't too simplistic.

The best way to answer that question is add more test cases.
Comment 4 Adele Peterson 2010-12-08 17:25:06 PST
I'm going to add a few more tests, with at least one that covers transformed controls.

(In reply to comment #3)
> (From update of attachment 75990 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75990&action=review
> 
> >> WebCore/rendering/RenderTextControlSingleLine.cpp:1132
> >> +        return innerRenderer->y();
> > 
> > I hope this isn't too simplistic.
> 
> The best way to answer that question is add more test cases.
Comment 5 Adele Peterson 2010-12-08 17:36:28 PST
Committed revision 73572.
Comment 6 WebKit Review Bot 2010-12-09 02:22:22 PST
http://trac.webkit.org/changeset/73572 might have broken GTK Linux 32-bit Release