Bug 50725 – REGRESSION (r72052): “Search” placeholder in MobileMe mail is positioned too high

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Adele Peterson]

“Search” placeholder in MobileMe mail is positioned too high

[Adele Peterson]

Created attachment 75990 [details]
patch

[Adele Peterson]

Comment on attachment 75990 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75990&action=review

> WebCore/rendering/RenderTextControlSingleLine.cpp:1132
> +        return innerRenderer->y();

I hope this isn't too simplistic.

[Darin Adler]

Comment on attachment 75990 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75990&action=review

>> WebCore/rendering/RenderTextControlSingleLine.cpp:1132
>> +        return innerRenderer->y();
> 
> I hope this isn't too simplistic.

The best way to answer that question is add more test cases.

[Adele Peterson]

I'm going to add a few more tests, with at least one that covers transformed controls.

(In reply to comment #3)
> (From update of attachment 75990 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=75990&action=review
> 
> >> WebCore/rendering/RenderTextControlSingleLine.cpp:1132
> >> +        return innerRenderer->y();
> > 
> > I hope this isn't too simplistic.
> 
> The best way to answer that question is add more test cases.

[Adele Peterson]

Committed revision 73572.

[WebKit Review Bot]

http://trac.webkit.org/changeset/73572 might have broken GTK Linux 32-bit Release