Bug 50724 – WebFrameProxy::canShowMIMEType should return true for PDF MIME types in the main frame

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

WebFrameProxy::canShowMIMEType should return true for PDF MIME types in the main frame

[Anders Carlsson]

Created attachment 75987 [details]
Patch

[Darin Adler]

Comment on attachment 75987 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75987&action=review

> WebKit2/UIProcess/WebFrameProxy.cpp:96
> +        Vector<String> mimeTypes = WebContext::pdfAndPostScriptMIMETypes();
> +        for (size_t i = 0; i < mimeTypes.size(); ++i) {
> +            if (equalIgnoringCase(mimeTypes[i], mimeType))
> +                return true;
> +        }

Seems really ugly to write out the loop like this. One benefit of using a set is that you don’t need to write the loop. You should factor the loop into a helper function so it’s easier to see what the code is doing.

[Anders Carlsson]

Committed r73569: <http://trac.webkit.org/changeset/73569>

[WebKit Review Bot]

http://trac.webkit.org/changeset/73569 might have broken GTK Linux 32-bit Release
The following tests are not passing:
fast/css/input-search-padding.html
fast/css/text-input-with-webkit-border-radius.html
fast/forms/box-shadow-override.html
fast/forms/control-restrict-line-height.html
fast/forms/input-appearance-height.html
fast/forms/placeholder-pseudo-style.html
fast/forms/placeholder-set-value.html
fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-placeholder-value-changed.html
fast/forms/search-rtl.html
fast/forms/search-styled.html
fast/forms/search-transformed.html
fast/forms/search-vertical-alignment.html
fast/forms/search-zoomed.html
fast/forms/searchfield-heights.html