Bug 50713 - [Qt] Move to BUILDING_WEBKIT flag as used by other ports (and away from BUILD_WEBKIT)
Summary: [Qt] Move to BUILDING_WEBKIT flag as used by other ports (and away from BUILD...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Minor
Assignee: Siddharth Mathur
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-12-08 13:43 PST by Siddharth Mathur
Modified: 2010-12-09 04:37 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.92 KB, patch)
2010-12-08 19:21 PST, Siddharth Mathur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Siddharth Mathur 2010-12-08 13:43:41 PST
All Webkit ports except Qt use BUILDING_WEBKIT to signal that Webkit's shared library/DLL is being compiled. We should preferably stick to this convention and not use our own BUILD_WEBKIT
Comment 1 Siddharth Mathur 2010-12-08 19:21:42 PST
Created attachment 76003 [details]
Patch
Comment 2 Laszlo Gombos 2010-12-08 23:54:16 PST
Comment on attachment 76003 [details]
Patch

LGTM, r+. 

Next time please add "[Qt] "  as a prefix of the title of the ChangeLog/bug if the change is specific to the Qt port.
Comment 3 WebKit Commit Bot 2010-12-09 03:11:23 PST
The commit-queue encountered the following flaky tests while processing attachment 76003 [details]:

http/tests/appcache/update-cache.html

Please file bugs against the tests.  These tests were authored by ap@webkit.org.  The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2010-12-09 03:13:09 PST
Comment on attachment 76003 [details]
Patch

Clearing flags on attachment: 76003

Committed r73602: <http://trac.webkit.org/changeset/73602>
Comment 5 WebKit Commit Bot 2010-12-09 03:13:14 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-12-09 04:37:33 PST
http://trac.webkit.org/changeset/73602 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
editing/selection/extend-by-character-002.html