wtf.pri should unix!symbian to avoid POSIX memory management code from being compile for Symbian.
Created attachment 75948 [details] exclude Symbian from trying to compile POSIX memory management code
Created attachment 75954 [details] no POSIXy love for Symbian
Comment on attachment 75954 [details] no POSIXy love for Symbian View in context: https://bugs.webkit.org/attachment.cgi?id=75954&action=review > JavaScriptCore/ChangeLog:5 > + Build fix for Symbian: don't compile POSIX memory management implementation We usually have a [Qt] prefix in the title for Qt-only changes. > JavaScriptCore/wtf/wtf.pri:46 > +unix!symbian: SOURCES += wtf/OSAllocatorPosix.cpp Don't we need a ":" to make it "unix:!symbian" ?
The existing syntax in the patch works OK, for example the following snippet prints "Hello Symbian" only without any warnings. I will fix the Changelog entry in a new patch. ## test.pro ## unix!symbian:message("Hello Unix") symbian:message("Hello Symbian")
Created attachment 76194 [details] updated patch with Changelog corrected.
Created attachment 76196 [details] Correct syntax and correct changelog (I need more sleep and/or coffee)
Comment on attachment 76196 [details] Correct syntax and correct changelog Looks sane to me.
Comment on attachment 76196 [details] Correct syntax and correct changelog Clearing flags on attachment: 76196 Committed r73842: <http://trac.webkit.org/changeset/73842>
All reviewed patches have been landed. Closing bug.