Bug 50707 - [Qt] Build fix for Symbian after recent allocator refactoring
Summary: [Qt] Build fix for Symbian after recent allocator refactoring
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Hardware S60 3rd edition
: P2 Normal
Assignee: Siddharth Mathur
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-12-08 12:46 PST by Siddharth Mathur
Modified: 2010-12-10 23:14 PST (History)
4 users (show)

See Also:


Attachments
exclude Symbian from trying to compile POSIX memory management code (453 bytes, patch)
2010-12-08 12:51 PST, Siddharth Mathur
no flags Details | Formatted Diff | Diff
no POSIXy love for Symbian (990 bytes, patch)
2010-12-08 13:17 PST, Siddharth Mathur
no flags Details | Formatted Diff | Diff
updated patch with Changelog corrected. (1022 bytes, patch)
2010-12-10 07:26 PST, Siddharth Mathur
no flags Details | Formatted Diff | Diff
Correct syntax and correct changelog (1023 bytes, patch)
2010-12-10 07:32 PST, Siddharth Mathur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Siddharth Mathur 2010-12-08 12:46:17 PST
wtf.pri should unix!symbian to avoid POSIX memory management code from being compile for Symbian.
Comment 1 Siddharth Mathur 2010-12-08 12:51:04 PST
Created attachment 75948 [details]
exclude Symbian from trying to compile POSIX memory management code
Comment 2 Siddharth Mathur 2010-12-08 13:17:58 PST
Created attachment 75954 [details]
no POSIXy love for Symbian
Comment 3 Laszlo Gombos 2010-12-09 08:37:52 PST
Comment on attachment 75954 [details]
no POSIXy love for Symbian

View in context: https://bugs.webkit.org/attachment.cgi?id=75954&action=review

> JavaScriptCore/ChangeLog:5
> +        Build fix for Symbian: don't compile POSIX memory management implementation 

We usually have a [Qt] prefix in the title for Qt-only changes.

> JavaScriptCore/wtf/wtf.pri:46
> +unix!symbian: SOURCES += wtf/OSAllocatorPosix.cpp

Don't we need a ":" to make it "unix:!symbian" ?
Comment 4 Siddharth Mathur 2010-12-09 08:45:40 PST
The existing syntax in the patch works OK, for example the following snippet prints "Hello Symbian" only without any warnings. I will fix the Changelog entry in a new patch. 

## test.pro ##
unix!symbian:message("Hello Unix")
symbian:message("Hello Symbian")
Comment 5 Siddharth Mathur 2010-12-10 07:26:47 PST
Created attachment 76194 [details]
updated patch with Changelog corrected.
Comment 6 Siddharth Mathur 2010-12-10 07:32:23 PST
Created attachment 76196 [details]
Correct syntax and correct changelog

(I need more sleep and/or coffee)
Comment 7 Eric Seidel (no email) 2010-12-10 20:58:51 PST
Comment on attachment 76196 [details]
Correct syntax and correct changelog

Looks sane to me.
Comment 8 WebKit Review Bot 2010-12-10 23:14:47 PST
Comment on attachment 76196 [details]
Correct syntax and correct changelog

Clearing flags on attachment: 76196

Committed r73842: <http://trac.webkit.org/changeset/73842>
Comment 9 WebKit Review Bot 2010-12-10 23:14:53 PST
All reviewed patches have been landed.  Closing bug.