RESOLVED FIXED 50701
[chromium] remove --use-drt and add --use-test-shell 
https://bugs.webkit.org/show_bug.cgi?id=50701
Summary [chromium] remove --use-drt and add --use-test-shell
Tony Chang
Reported 2010-12-08 11:26:49 PST
[chromium] remove --use-drt and add --use-test-shell
Attachments
Patch (16.88 KB, patch)
2010-12-08 11:28 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (21.84 KB, patch)
2010-12-10 10:39 PST, Tony Chang 		ojan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-12-08 11:28:47 PST
Created attachment 75934 [details] Patch
Dirk Pranke
Comment 2 2010-12-08 11:40:28 PST
Patch LGTM as well ... Do we still use the ChromiumDriver code on Windows and Linux and only use the WebKitDriver code on the Mac? I wonder if that has something to do with the flakiness I'm seeing.
Tony Chang
Comment 3 2010-12-08 12:04:52 PST
(In reply to comment #2) > Do we still use the ChromiumDriver code on Windows and Linux and only use the WebKitDriver code on the Mac? I wonder if that has something to do with the flakiness I'm seeing. Yes, I think that's right. I swapped to ChromiumDriver on Linux because of random test timeouts, so it might be related. We should probably just switch to ChromiumDriver until we can figure out why WebKitDriver is flaky for Chromium DRT.
Dirk Pranke
Comment 4 2010-12-08 12:26:59 PST
(In reply to comment #3) > (In reply to comment #2) > > Do we still use the ChromiumDriver code on Windows and Linux and only use the WebKitDriver code on the Mac? I wonder if that has something to do with the flakiness I'm seeing. > > Yes, I think that's right. I swapped to ChromiumDriver on Linux because of random test timeouts, so it might be related. We should probably just switch to ChromiumDriver until we can figure out why WebKitDriver is flaky for Chromium DRT. Okay, I'll test that locally and report back.
Tony Chang
Comment 5 2010-12-10 10:39:44 PST
Created attachment 76219 [details] Patch
Tony Chang
Comment 6 2010-12-10 10:40:33 PST
I found a few more uses of use_drt outside of the layout_tests dir (e.g., the ews bots) so I updated the patch.
Tony Chang
Comment 7 2010-12-10 11:24:42 PST
Committed r73748: <http://trac.webkit.org/changeset/73748>
Note You need to log in before you can comment on or make changes to this bug.