Bug 50685 - [Qt] Support OrientationChange event
Summary: [Qt] Support OrientationChange event
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: qi
Keywords: Qt
: 36829 (view as bug list)
Depends on:
Reported: 2010-12-08 07:03 PST by qi
Modified: 2011-02-23 10:45 PST (History)
7 users (show)

See Also:

patch (3.93 KB, patch)
2010-12-08 07:26 PST, qi
no flags Details | Formatted Diff | Diff
patch for qtwebkit2.1 (4.33 KB, application/octet-stream)
2010-12-13 07:30 PST, Chang Shu
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description qi 2010-12-08 07:03:18 PST
We need support "OrientationChange" event in Qt.

Comment 1 qi 2010-12-08 07:26:47 PST
Created attachment 75902 [details]

Get the OrientationChange event from qtmobility, then send to webkit.
Comment 2 Kenneth Rohde Christiansen 2010-12-08 07:34:48 PST
Comment on attachment 75902 [details]

I wonder how this affects the media feature -webkit-orientation.

like if I do 

@media screen and (-webkit-orientation: landscape) {
   body { background-color: green; }
Comment 3 qi 2010-12-08 07:44:53 PST
I am not really sure what the "-webkit-orientation" is. But I think my code will not affect this feature, because this code just listen for sensor and send event to webkit. The behavior depends on webkit, if the webkit want to force the orientation in this case, they can ignore this event.
Comment 4 WebKit Commit Bot 2010-12-08 19:11:06 PST
Comment on attachment 75902 [details]

Clearing flags on attachment: 75902

Committed r73584: <http://trac.webkit.org/changeset/73584>
Comment 5 WebKit Commit Bot 2010-12-08 19:11:19 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Chang Shu 2010-12-13 07:30:17 PST
Created attachment 76384 [details]
patch for qtwebkit2.1

Create patch for qtwebkit2.1
Comment 7 Suresh Voruganti 2010-12-13 13:58:31 PST
Fix required for Qtwebkit 2.1/2.2. 

Developer has also attached the back ported version of the patch for Qtwebkit 2.1/2.2
Comment 8 Ademar Reis 2010-12-20 13:05:53 PST
Revision r73584 cherry-picked into qtwebkit-2.2 with commit f339029 <http://gitorious.org/webkit/qtwebkit/commit/f339029>
Comment 9 Diego Gonzalez 2011-02-23 10:45:17 PST
*** Bug 36829 has been marked as a duplicate of this bug. ***