Bug 50684 – Default styling rules for the figure and figcaption elements

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Peter Beverloo]

This patch adds default styling rules for the <figure> and <figcaption> elements to html.css.

The elements themselfes were added by Adam Barth during work on the tree-builder.

[Peter Beverloo]

Created attachment 75896 [details]
Patch

[Adam Barth]

Comment on attachment 75896 [details]
Patch

Looks reasonable to me.

[Maciej Stachowiak]

Comment on attachment 75896 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=75896&action=review

Also it looks like the test cases don't test the styles.

> WebCore/css/html.css:90
>      margin: 1__qem 40px 1em 40px

I don't think this rule is right for figure. The 1__qem invokes a quirk in quirks mode that is needed for historical reasons for blockquote, but there is no need to have the same quirk for figure.

[Peter Beverloo]

Created attachment 76035 [details]
Revised patch

Thank you for the review. I have addressed your points, figure now has its own definition in html.css and I've added testing of the default styles.

I'd appreciate it if you could check whether my approach with the "emSize" variable in the tests is correct.

[Maciej Stachowiak]

Comment on attachment 76035 [details]
Revised patch

r=me

[WebKit Commit Bot]

Comment on attachment 76035 [details]
Revised patch

Clearing flags on attachment: 76035

Committed r73613: <http://trac.webkit.org/changeset/73613>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.