Bug 50680 - WebTouchEvent::isTouchEventType() does not take into account the type TouchCancel
Summary: WebTouchEvent::isTouchEventType() does not take into account the type TouchCa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-12-08 04:38 PST by Benjamin Poulain
Modified: 2010-12-08 18:16 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.16 KB, patch)
2010-12-08 04:50 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2010-12-08 04:38:48 PST 
WebTouchEvent::isTouchEventType() does not take into account the type TouchCancel. This makes the constructor of the class fail in debug due to ASSERT(isTouchEventType(type));.
Comment 1 Benjamin Poulain 2010-12-08 04:50:18 PST 
Created attachment 75891 [details]
Patch
Comment 2 Andreas Kling 2010-12-08 04:52:37 PST 
Comment on attachment 75891 [details]
Patch

Good catch, r=me
Comment 3 WebKit Commit Bot 2010-12-08 17:10:30 PST 
The commit-queue encountered the following flaky tests while processing attachment 75891 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html
transitions/change-values-during-transition.html

Please file bugs against the tests.  These tests were authored by dumi@chromium.org, jparent@google.com, mihaip@chromium.org, and pol@apple.com.  The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2010-12-08 18:16:00 PST 
Comment on attachment 75891 [details]
Patch

Clearing flags on attachment: 75891

Committed r73581: <http://trac.webkit.org/changeset/73581>
Comment 5 WebKit Commit Bot 2010-12-08 18:16:05 PST 
All reviewed patches have been landed.  Closing bug.