Bug 50676 - [GTK] Layering violation in ContextMenuGtk.cpp
Summary: [GTK] Layering violation in ContextMenuGtk.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 50586
  Show dependency treegraph
 
Reported: 2010-12-08 03:24 PST by Martin Robinson
Modified: 2010-12-08 11:17 PST (History)
2 users (show)

See Also:


Attachments
Patch for this issue (6.36 KB, patch)
2010-12-08 03:30 PST, Martin Robinson
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-12-08 03:24:29 PST
ContextMenuGtk shouldn't know about ContextMenuController. This is a companion fix to http://trac.webkit.org/changeset/73469 .
Comment 1 Martin Robinson 2010-12-08 03:30:30 PST
Created attachment 75884 [details]
Patch for this issue
Comment 2 John Sullivan 2010-12-08 05:52:43 PST
Comment on attachment 75884 [details]
Patch for this issue

View in context: https://bugs.webkit.org/attachment.cgi?id=75884&action=review

> WebKit/gtk/webkit/webkitwebview.cpp:268
> +static void popupMenuItemActivated(GtkMenuItem* item, ContextMenuController* controller)

To keep the terminology consistent, I suggest using "contextMenu" rather than "popupMenu" in the name of this function.
Comment 3 Martin Robinson 2010-12-08 11:17:45 PST
Committed r73534: <http://trac.webkit.org/changeset/73534>