Bug 50675 - [GTK] bump glib/libsoup versions
Summary: [GTK] bump glib/libsoup versions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 50344 50747
  Show dependency treegraph
 
Reported: 2010-12-08 03:05 PST by Dan Winship
Modified: 2011-01-29 04:57 PST (History)
3 users (show)

See Also:


Attachments
patch to bump versions and remove now-unnecessary conditionals (17.54 KB, patch)
2010-12-08 03:11 PST, Dan Winship
no flags Details | Formatted Diff | Diff
updated patch, requires libsoup 2.33.1 (19.02 KB, patch)
2010-12-09 03:28 PST, Dan Winship
no flags Details | Formatted Diff | Diff
Patch (13.79 KB, patch)
2011-01-28 12:15 PST, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff
Patch (13.79 KB, patch)
2011-01-28 14:25 PST, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Winship 2010-12-08 03:05:52 PST
As part of moving the soup request/cache stuff out of bugzilla, we will need to depend on the latest libsoup. The latest libsoup depends on the latest glib, and we'd also need to depend on the latest glib for bug 50344. So...
Comment 1 Dan Winship 2010-12-08 03:11:10 PST
Created attachment 75882 [details]
patch to bump versions and remove now-unnecessary conditionals
Comment 2 Xan Lopez 2010-12-08 11:07:21 PST
Comment on attachment 75882 [details]
patch to bump versions and remove now-unnecessary conditionals

Looks good, we'll put it in cq when the bots have libsoup master.
Comment 3 Xan Lopez 2010-12-08 11:08:00 PST
Gustavo, comment here when we have libsoup master packages for the bots. kthxbye.
Comment 4 Dan Winship 2010-12-09 03:28:30 PST
Created attachment 76039 [details]
updated patch, requires libsoup 2.33.1

I just committed a configure change to libsoup to make it be "2.33.1" after the addition of the cache/request stuff  (bug 50747), so we should require that.
Comment 5 Xan Lopez 2010-12-09 16:52:36 PST
Comment on attachment 76039 [details]
updated patch, requires libsoup 2.33.1

As before, I'll add to cq when possible.
Comment 6 Eric Seidel (no email) 2010-12-14 01:26:55 PST
Comment on attachment 75882 [details]
patch to bump versions and remove now-unnecessary conditionals

Cleared Xan Lopez's review+ from obsolete attachment 75882 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 7 Gustavo Noronha (kov) 2011-01-28 12:15:54 PST
Created attachment 80479 [details]
Patch
Comment 8 Gustavo Noronha (kov) 2011-01-28 13:51:52 PST
Attachment 80479 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7574381
Comment 9 Gustavo Noronha (kov) 2011-01-28 14:25:05 PST
Created attachment 80497 [details]
Patch
Comment 10 Gustavo Noronha (kov) 2011-01-29 02:17:48 PST
Comment on attachment 80497 [details]
Patch

This was previously reviewed by Xan, so I'm marking it for landing.
Comment 11 WebKit Commit Bot 2011-01-29 03:38:46 PST
The commit-queue encountered the following flaky tests while processing attachment 80497 [details]:

http/tests/xmlhttprequest/logout.html bug 52047 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2011-01-29 03:40:10 PST
Comment on attachment 80497 [details]
Patch

Clearing flags on attachment: 80497

Committed r77061: <http://trac.webkit.org/changeset/77061>
Comment 13 WebKit Commit Bot 2011-01-29 03:40:16 PST
All reviewed patches have been landed.  Closing bug.
Comment 14 WebKit Commit Bot 2011-01-29 04:57:37 PST
The commit-queue encountered the following flaky tests while processing attachment 80497 [details]:

http/tests/xmlhttprequest/remember-bad-password.html bug 51733 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.