Bug 50670 – HttpServerBase should not raise OSError when it fails to delete stale log files

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Tools / Tests

[Yuta Kitamura]

Chromium Windows bots sometimes fail to delete stale log files (in HttpServerBase.remove_log_files), especially when it restarts the test to check flakiness.

I think we should just log the issue when we have failed to delete files and continue running, rather than die with an exception.

Stack trace:

2010-12-07 21:21:44,023 3044 run_webkit_tests.py:619 INFO Exception raised, exiting
Traceback (most recent call last):
  File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\new-run-webkit-tests", line 38, in <module>
    sys.exit(run_webkit_tests.main())
  File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 1636, in main
    return run(port_obj, options, args)
  File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 1328, in run
    num_unexpected_results = test_runner.run(result_summary)
No handlers could be found for logger "webkitpy.common.system"
  File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 722, in run
    self._run_tests(failures.keys(), retry_summary)
  File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 612, in _run_tests
    message_broker.run_message_loop()
  File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\layout_package\dump_render_tree_thread.py", line 337, in _covered_run
    self._run(test_runner=None, result_summary=None)
  File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\layout_package\dump_render_tree_thread.py", line 414, in _run
    self._start_servers_with_lock()
  File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\layout_package\dump_render_tree_thread.py", line 550, in _start_servers_with_lock
    self._port.start_websocket_server()
  File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\base.py", line 548, in start_websocket_server
    self._websocket_server.start()
  File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\websocket_server.py", line 153, in start
    self.remove_log_files(self._output_dir, log_prefix)
  File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\http_server_base.py", line 81, in remove_log_files
    os.remove(full_path)
WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'e:\\b\\build\\slave\\webkit-rel-webkit-org\\build\\src\\webkit\\Release\\..\\../../layout-test-results\\pywebsocket.ws.log-07Dec2010-211346-out.txt'

[Yuta Kitamura]

Created attachment 75874 [details]
Patch

[Yuta Kitamura]

Eric, could you take a look at this patch?

[Eric Seidel (no email)]

The example you give is one where some other httpd server is still running.  Ignoring that case seems like a bad idea.  We should stop the other httpd server or fail.

[Tony Chang]

*** This bug has been marked as a duplicate of bug 50712 ***

[Yuta Kitamura]

Tony, thank you for taking care of this failure.